Skip to content

Repo: Netlify PR deploys fail on latest Node.js 18.19.0 #8025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
auvred opened this issue Dec 5, 2023 · 3 comments
Closed

Repo: Netlify PR deploys fail on latest Node.js 18.19.0 #8025

auvred opened this issue Dec 5, 2023 · 3 comments
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@auvred
Copy link
Member

auvred commented Dec 5, 2023

Suggestion

Logs: https://app.netlify.com/sites/typescript-eslint/deploys/656cda722b027400084ae549#L64-L91

This is because the latest version 18.x of Node.js (18.19.0) is being used. It contains breaking changes for tsx package used in deployment. It has been fixed on tsx side in the v4.6.1, but as I understand it, we can't just bump the tsx version, because tsx@4 doesn't support Node.js v16, although v16 it's still used in ci:

typescript-eslint/.github/workflows/ci.yml

Line 162 in cc2c6d3

node-version: [16, 20]

So we can:

  1. Drop Node.js 16 support (it's already unmaintained) and bump tsx
  2. Pin Node.js version to 18.18.2 in Netlify
  3. Use something other than tsx

I guess the 1 is the best option?
@auvred auvred added repo maintenance things to do with maintenance of the repo, and not with code/docs triage Waiting for team members to take a look labels Dec 5, 2023
@JoshuaKGoldberg
Copy link
Member

🤔 per https://docs.netlify.com/configure-builds/manage-dependencies/#node-js-and-javascript it looks like we've pinned Node to 16 in the UI...

Screenshot of Dependency management settings in Netlify showing Node 16

We wouldn't be able to drop Node.js 16 support until our next major version, as that'd be a breaking change. So for now we can either use something other than tsx or pin the Node.js version in Netlify to <=18.18.2.

@JoshuaKGoldberg
Copy link
Member

Ah but environment variables are used instead - and NODE_VERSION was set to 18. I switched it to 18.18.2 just now. So this should be fixed. Thanks for filing!

If not, we can re-open and take another look.

@JoshuaKGoldberg JoshuaKGoldberg removed the triage Waiting for team members to take a look label Dec 5, 2023
This was referenced Dec 9, 2023
Closed
Merged
@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Dec 11, 2023 •
edited
Loading

Following #8045 -> #8048, we should be able to remove that env variable. I've set a reminder for January 3rd, just in case an older PR doesn't have the updated version of tsx.

Edit: done 👍

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JoshuaKGoldberg @auvred