Skip to content

Repo: Move eslint-plugin-tslint to a separate repo #8118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Dec 24, 2023 · 3 comments · Fixed by #8366
Closed

Repo: Move eslint-plugin-tslint to a separate repo #8118

JoshuaKGoldberg opened this issue Dec 24, 2023 · 3 comments · Fixed by #8366
Assignees
@JoshuaKGoldberg
Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Dec 24, 2023 •
edited
Loading

Suggestion

@typescript-eslint/eslint-plugin-tslint is an ESLint plugin that allows running TSLint rules within ESLint. It's made to help folks migrate off TSLint towards ESLint.

eslint-plugin-tslint has existed in this monorepo for many years because that was a convenient way to keep it maintained alongside our other packages.

But, we keep synced package versions (for good reason - see #7521). So eslint-plugin-tslint has been getting version bumps steadily for years ... despite no new issues being filed on it for quite some time. A query for relevant issues with label package:eslint-plugin-tslint shows that we haven't had anything come up since 2020.

Keeping the package around is also a maintenance burden. For example, in #7752, its unit tests are failing with EXPERIMENTAL_useProjectService enabled. I really don't think we need to test the case of someone running with eslint-plugin-tslint and the new project service.

Proposal: let's make a new repository for eslint-plugin-tslint.

  • It won't need to automatically publish new releases weekly with the rest of our packages.
  • Its only dependencies entry is @typescript-eslint/utils, which we can switch to a ^ version matcher.
  • We'll still be able to actively maintain the repository if anything comes up

(originally pointed out by @bradzacher in a private triage team chat)
@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for team members to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs labels Dec 24, 2023
@bradzacher
Copy link
Member

We re released over three thousand versions of that plugin due to automated version syncing - but the code hasn't changed in a very long time.

TSLint is long dead and buried by this point so most people have migrated off of it. The stragglers also aren't likely keeping up-to-date with their eslint versions (or else they'd kill tslint!)

So yeah moving it to a new repo for it to sit and no longer be auto released would be the best option for everyone, I think. Also further distances our main repo from TSLint to help people not mix up the names.

@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Feb 4, 2024
@JoshuaKGoldberg
Copy link
Member Author 

git subtree split -P packages/eslint-plugin-tslint -b standalone-eslint-plugin-tslint

✨

@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Feb 4, 2024
@JoshuaKGoldberg
Copy link
Member Author

Moved to: https://github.com/typescript-eslint/eslint-plugin-tslint

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Feb 4, 2024
Merged
3 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
accepting prs Go ahead, send a pull request that resolves this issue repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: extract eslint-plugin-tslint to new repository JoshuaKGoldberg/typescript-eslint
2 participants
@JoshuaKGoldberg @bradzacher