Skip to content

Repo: codecov coverage reports are not longer uploaded #8166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
auvred opened this issue Jan 2, 2024 · 2 comments · Fixed by #8167
Closed

Repo: codecov coverage reports are not longer uploaded #8166

auvred opened this issue Jan 2, 2024 · 2 comments · Fixed by #8167
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@auvred
Copy link
Member

auvred commented Jan 2, 2024

Suggestion

This PR #7567 pinned PRIMARY_NODE_VERSION variable in CI to >=20.6.1

typescript-eslint/.github/workflows/ci.yml

Lines 16 to 17 in e566a5d

env:
PRIMARY_NODE_VERSION: '>=20.6.1'

But this variable is also compared to matrix.node-version which van be 16 or 20

typescript-eslint/.github/workflows/ci.yml

Lines 194 to 217 in e566a5d

# collect coverage on the primary node version
# we don't collect coverage on other node versions so they run faster
# note that we don't do this as a single `run` with a flag because some
# packages don't collect coverage on purpose, so forcing `--coverage=true`
# would override the config
- name: Run unit tests with coverage for ${{ matrix.package }}
if: env.PRIMARY_NODE_VERSION == matrix.node-version
run: npx nx test ${{ matrix.package }}
env:
CI: true
- name: Run unit tests for ${{ matrix.package }}
if: env.PRIMARY_NODE_VERSION != matrix.node-version
run: npx nx test ${{ matrix.package }} --coverage=false
env:
CI: true
- name: Store coverage for uploading
if: env.PRIMARY_NODE_VERSION == matrix.node-version
uses: actions/upload-artifact@v3
with:
name: ${{ matrix.package }}-coverage
path: packages/${{ matrix.package }}/coverage/lcov.info
# Sadly 1 day is the minimum
retention-days: 1

'>=20.6.1' == '20' -> false

Thus, the coverage isn't collected and uploaded

I think we can unpin it since the current version of Node.js is already 20.10.0
@auvred auvred added repo maintenance things to do with maintenance of the repo, and not with code/docs triage Waiting for team members to take a look labels Jan 2, 2024
@auvred auvred mentioned this issue Jan 2, 2024
Merged
3 tasks
@auvred
Copy link
Member Author

auvred commented Jan 5, 2024

Okay, it works with PRIMARY_NODE_VERSION set to 20: #8167 (comment)

@JoshuaKGoldberg JoshuaKGoldberg added bug Something isn't working accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels Jan 11, 2024
@JoshuaKGoldberg
Copy link
Member

🙃 lovely, thanks for filing. Good spot.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: unpin primary node version in ci auvred/typescript-eslint
2 participants
@JoshuaKGoldberg @auvred