Skip to content

ESLint v9 Support #8211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
40 of 42 tasks
Tracked by #79
, #26 ,  #26 ,  #978 ,  #9476 ,  #12 ,  #65 ,  #1 ,  #118
...
bradzacher opened this issue Jan 7, 2024 · 29 comments
Closed
40 of 42 tasks
Tracked by #79
, #26 ,  #26 ,  #978 ,  #9476 ,  #12 ,  #65 ,  #1 ,  #118
...

ESLint v9 Support #8211

bradzacher opened this issue Jan 7, 2024 · 29 comments
Labels
accepting prs Go ahead, send a pull request that resolves this issue dependencies Issue about dependencies of the package locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.
Milestone
8.0.0

Comments

@bradzacher
Copy link
Member

bradzacher commented Jan 7, 2024 •
edited
Loading

The v8 versions of typescript-eslint starting with v8.0.0-alpha.10 now support ESLint v9. Hooray! 🙌

If you still have problems with typescript-eslint and ESLint v9:

  1. Please make sure you're using typescript-eslint@8.0.0-alpha.10 or newer
  2. Go through our issue chooser to file a new issue reporting your problems
    • That issue template includes searching for existing issues matching your problem - please do not file duplicate issues

Note that we do not plan on backporting ESLint v9 support to v7 versions of typescript-eslint. There are a lot of breaking changes inherent to our ESLint v9 support.

Previous issue body summarising work

ESLint has released v9.

Note that it contains breaking changes and as such we do not currently support it. It may work or it may not.

We are not accepting issues against v9 until we have official support - so please do not file issues with crashes or bugs for now and please do not comment on this issue telling us about crashes.

If you believe you have a bug when using ESLint v8 - please file a new issue.
If you need some help setting up / configuring your project - please visit our discord.

If you'd like to help contribute towards support feel free to comment!

Ongoing Work

Breaking Changes

  • correct camelcase rule schema for allow option
  • move AST traversal into SourceCode
  • disallow multiple configuration comments for same rule
  • default for enforceForClassMembers in no-useless-computed-key
  • no-unused-vars default caughtErrors to ‘all’: Enhancement: [no-unused-vars] Update for ESLint 9 defaults #8967
  • no-unused-vars varsIgnorePattern behavior with catch arguments: Enhancement: [no-unused-vars] Update for ESLint 9 defaults #8967
  • no-restricted-imports allow multiple config entries for same path
  • no-sequences rule schema correction
  • no-invalid-regexp make allowConstructorFlags case-sensitive
  • no-inner-declaration new default behaviour and option
  • add two more cases to no-implicit-coercion
  • Remove valid-jsdoc and require-jsdoc
  • handle --output-file for empty output when saving to disk
  • upgrade eslint-scope@8.0.0
  • configuration comments with just severity should retain options
  • Remove CodePath#currentSegments
  • remove no-inner-declarations from eslint:recommended
  • Rename FlatESLint to ESLint
  • skip running warnings in --quiet mode
  • Set default schema: [], drop support for function-style rules
  • Switch Linter to flat config by default: Enhancement(utils): Update types ESLint v9 Linter class (flat config) #8968
  • Parsing ‘exported’ comment using parseListConfig
  • Behavior of CLI when no arguments are passed
  • Update shouldUseFlatConfig and CLI so flat config is default
  • deprecate no-new-symbol, recommend no-new-native-nonconstructor
  • Update eslint:recommended configuration
  • drop support for string configurations in flat config array
  • Remove SourceCode#getComments()
  • Remove deprecated context methods
  • Swap FlatESLint-ESLint, FlatRuleTester-RuleTester in API Enhancement(utils): Swap FlatESLint-ESLint, FlatRuleTester-RuleTester in API #8970
  • remove formatters except html, json(-with-metadata), and stylish
  • Require Node.js ^18.18.0 || ^20.9.0 || >=21.1.0

Changes we're treating as non-breaking

Per discussion in #8211, these augmentations fix previous gaps in the RuleTester. We'll treat them as non-breaking bug fixes so they can land in the v7 major version ahead of v8.
@bradzacher bradzacher added breaking change This change will require a new major version to be released dependencies Issue about dependencies of the package labels Jan 7, 2024
@bradzacher bradzacher added this to the 7.0.0 milestone Jan 7, 2024
@bradzacher bradzacher mentioned this issue Jan 7, 2024
Merged
9 tasks
This was referenced Jan 8, 2024
Draft
Closed
@bradzacher bradzacher pinned this issue Jan 27, 2024
@otakustay otakustay mentioned this issue Feb 13, 2024
Open
11 tasks
@heymartinadams

This comment was marked as resolved.

Sign in to view
@JoshuaKGoldberg

This comment was marked as resolved.

Sign in to view
@heymartinadams

This comment was marked as resolved.

Sign in to view
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@typescript-eslint typescript-eslint deleted a comment from github-actions bot Feb 16, 2024
@typescript-eslint typescript-eslint deleted a comment from github-actions bot Feb 16, 2024
@heymartinadams heymartinadams mentioned this issue Feb 16, 2024
Closed
2 tasks
@bradzacher
Copy link
Member Author

bradzacher commented Feb 16, 2024 •
edited
Loading

If you glance at the implementation you'll see that the helper is the identity function -- if you don't use the extends feature it adds.

That means that writing export default tseslint.config(...) is semantically the same as export default [...];. The difference is that the latter is untyped, but the former has strict types defined. This means your config can be checked -- mistakes will be flagged and you'll get auto-complete with each property fully documented via jsdoc.

We introduced this util because it provides a simple way for people to typecheck their configs. Otherwise people need to annotate the array with a jsdoc type which is very cumbersome and verbose:

/** @type {import('@typescript-eslint/utils').TSESLint.FlatConfigArray} */
export default [...];

// vs

export default tseslint.config(...);

We can definitely clarify this in the docs if it wasn't clear that the util isn't required.

@dotNomad dotNomad mentioned this issue Feb 26, 2024
Closed
@JoshuaKGoldberg JoshuaKGoldberg removed the breaking change This change will require a new major version to be released label Mar 25, 2024
@dotNomad dotNomad mentioned this issue Apr 3, 2024
Closed
@trivikr

This comment was marked as resolved.

Sign in to view
@bradzacher
Copy link
Member Author

bradzacher commented Apr 5, 2024 •
edited
Loading

v9 has officially released
https://eslint.org/blog/2024/04/eslint-v9.0.0-released/

Note that it contains breaking changes and as such we do not currently support it. It may work or it may not.

This issue tracks our official support.

Note that we are not accepting issues against v9 until we have official support - so please do not file issues with crashes or bugs for now and please do not comment on this issue telling us about crashes.

If you'd like to help contribute towards support feel free to comment!
See the comment below for more info

@bradzacher bradzacher added the accepting prs Go ahead, send a pull request that resolves this issue label Apr 6, 2024
@bradzacher bradzacher mentioned this issue Apr 6, 2024
Merged
3 tasks
@sebdanielsson sebdanielsson mentioned this issue Apr 6, 2024
Closed
1 task
@jamesgpearce
Copy link

Don't want to add to the noise, but did want to say thank you for being so clear and organized about what is supported and what the status is. Saved me a morning of wrestling with the immediate v9.0 fallout; I know to wait! 🙏

@ocavue ocavue mentioned this issue Apr 7, 2024
Closed
1 task
@Nivl Nivl mentioned this issue Apr 7, 2024
Closed
1 task
@nnmax nnmax mentioned this issue Apr 7, 2024
Open
5 tasks
HiromiShikata added a commit to HiromiShikata/npm-cli-gh-projects-working-time-reporter that referenced this issue May 11, 2024
@HiromiShikata
chore: use eslint v8 until support of typescript-eslint in renovate.json
1820198 
typescript-eslint/typescript-eslint#8211
HiromiShikata added a commit to HiromiShikata/template-typescript-npm-cli that referenced this issue May 11, 2024
@HiromiShikata
chore: use eslint v8 until starting support from typescript-eslint / …
2bb9bcb 
…ref typescript-eslint/typescript-eslint#8211
HiromiShikata added a commit to HiromiShikata/repositories-management that referenced this issue May 11, 2024
@HiromiShikata
chore: use eslint v8 until starting support from typescript-eslint / …
7b8b0d1 
…ref typescript-eslint/typescript-eslint#8211
@zemd zemd mentioned this issue May 12, 2024
Closed
26 tasks
@theoludwig theoludwig mentioned this issue May 12, 2024
Closed
@JoshuaKGoldberg
Copy link
Member

Now that #9002 is merged, the v8 versions of typescript-eslint starting with v8.0.0-alpha.10 now support ESLint v9. Hooray! 🙌

If you still have problems with typescript-eslint and ESLint v9:

  1. Please make sure you're using typescript-eslint@8.0.0-alpha.10 or newer
  2. Go through our issue chooser to file a new issue reporting your problems
    • That issue template includes searching for existing issues matching your problem - please do not file duplicate issues

Note that we do not plan on backporting ESLint v9 support to v7 versions of typescript-eslint. There are a lot of breaking changes inherent to our ESLint v9 support.

If any enterprising individual wants to try onboarding us in typescript-eslint to ESLint v9, #9082 tracks that as a followup.

This was referenced May 13, 2024
Closed
Merged
@jacobtylerwalls jacobtylerwalls mentioned this issue May 13, 2024
Merged
OmerMakesStuff added a commit to OmerMakesStuff/project-template that referenced this issue May 15, 2024
@OmerMakesStuff
Deps: Downgrade ESLint to v8
9417d6e 
Current stable version of Typescript-eslint doesn't support ESLint v9
yet, see
typescript-eslint/typescript-eslint#8211
@sawyerh sawyerh mentioned this issue May 15, 2024
Closed
1 task
@Gcommer Gcommer mentioned this issue May 16, 2024
Closed
This was referenced May 16, 2024
Open
Open
@javierbrea javierbrea mentioned this issue May 16, 2024
Closed
@auvred auvred mentioned this issue May 17, 2024
Closed
4 tasks
@BenoitZugmeyer BenoitZugmeyer mentioned this issue May 17, 2024
Open
8 tasks
@yuheiy yuheiy mentioned this issue May 18, 2024
Closed
@SaekiTominaga SaekiTominaga mentioned this issue May 18, 2024
Closed
@karlhorky karlhorky mentioned this issue May 18, 2024
Closed
4 tasks
@bradzacher bradzacher mentioned this issue May 19, 2024
Closed
4 tasks
@karlhorky karlhorky mentioned this issue May 19, 2024
Closed
4 tasks
@wakamsha wakamsha mentioned this issue May 20, 2024
Closed
This was referenced May 20, 2024
Open
Open
@alixlahuec alixlahuec mentioned this issue May 20, 2024
Closed
1 task
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2024
@bradzacher bradzacher unpinned this issue Oct 9, 2024
@bradzacher bradzacher added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Apr 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue dependencies Issue about dependencies of the package locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests