Skip to content

Bug: [prefer-readonly] prefer-readonly should not consider accessors #8299

Closed
@Jamesernator

Description

@Jamesernator

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=5.3.3&fileType=.tsx&code=FAYwNghgzlAEBiB7RsDexawA4CcCWAbhAC4CmsEIIpMiOFVsAvLAMwDcwGD1t9AxJRDNYAFk4BfIA&eslintrc=N4KABGBEBOCuA2BTAzpAXGUEKQAIBcBPABxQGNoBLY-AWhXkoDt8B6Y6RAM0Wls4CGAEwD2TeIXRRe0EdEjgwAXxBKgA&tsconfig=N4KABGBEDGD2C2AHAlgGwKYCcDyiAuysAdgM6QBcYoEEkJemy0eAcgK6qoDCAFutAGsylBm3TgwAXxCSgA&tokens=false

Repro Code

class Foo {
  private accessor acc = 3;

  accessor #acc = 4;
}

ESLint Config

module.exports = {
  "rules": {
    "@typescript-eslint/prefer-readonly": "error"
  }
};

tsconfig

{
  "compilerOptions": {
    "strictNullChecks": true
  }
}

Expected Result

Accessors should be ignored by prefer-readonly as they cannot be marked as readonly.

Actual Result

A broken fix is done that adds readonly to the accessors:

class Foo {
  private accessor readonly acc = 3;

  accessor readonly #acc = 4;
}

Additional Info

I will make a PR for this.

Metadata

Metadata

Assignees

No one assigned

    Labels

    accepting prsGo ahead, send a pull request that resolves this issuebugSomething isn't workingpackage: eslint-pluginIssues related to @typescript-eslint/eslint-plugin

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions