I think that this behaviour is still correct. In most code any form of TS comment is a code smell.

So having an error to warn against using @ts-expect-error is good practice.

Having an error to warn against @ts-ignore is good too - because it doesn't error if it suppresses nothing.

Think of it this way: the rules are saying "hey 100% definitely do not use @ts-ignore, prefer @ts-expect-error but also you shouldn't use that unless you really mean it".

If you use the "correct" suppression you only need one disable comment to say "yeah I'm doing this on purpose". If you use the "incorrect" one you need two to say "I'm really, really doing this on purpose and I know I'm breaking the rules".

No, I mean the rules do exactly the same thing, they both warn on @ts-ignore-error.

@ts-expect-error is perfectly allowed by both rules

I see how that ban-ts-comment actually includes a special message to suggest using ts-expect-error if you use ts-ignore.

So you are indeed correct - by default prefer-expect-error is a subset of ban-ts-comment.

We should just remove the former entirely.

Cc @typescript-eslint/triage-team

I had the idea too; I just thought prefer-expect-error had a very educative and actionable error message/name.

Yeah the name is nice but ban-ts-comment has the same error message.

+1 to this: if there's anything prefer-expect-error does better around messaging, part of the deprecation should involve moving that over to ban-ts-comment.

Yep, ban-ts-comment basically does the same, with one difference: prefer-expect-error provides autofix, while ban-ts-comment provides editor suggestion, which I think is nicer!

But while looking through the ban-ts-comment code, I noticed one possibly blocking thing: it doesn't report on multiline block comments, while prefer-expect-error does:

Assume we have the following code:

/**  some text here
   @ts-ignore */
const foo: string = 1

@typescript-eslint/prefer-ts-expect-error reports ✅ playground

@typescript-eslint/ban-ts-comment doesn't report ❌ playground

I think ban-ts-comment should cover this case to completely replace prefer-ts-expect-error.

Filed #8368