Skip to content

Enhancement: Remove IsNullableTypeOptions from type-utils #8931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
4 tasks done
JoshuaKGoldberg opened this issue Apr 15, 2024 · 1 comment
Closed
4 tasks done

Enhancement: Remove IsNullableTypeOptions from type-utils #8931

JoshuaKGoldberg opened this issue Apr 15, 2024 · 1 comment
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released enhancement New feature or request good first issue Good for newcomers locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.
Milestone
8.0.0

Comments

@JoshuaKGoldberg
Copy link
Member

Before You File a Proposal Please Confirm You Have Done The Following...

Relevant Package

ast-spec

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Description

Following #8089: we noticed that the IsNullableTypeOptions interface is never actually used in the places it's taken in, such as the isNullableType function later in the file:

typescript-eslint/packages/type-utils/src/predicates.ts

Lines 9 to 18 in 85ae4a8

export interface IsNullableTypeOptions {
/**
* @deprecated - this flag no longer does anything and will be removed in the next major
*/
isReceiver?: boolean;
/**
* @deprecated - this flag no longer does anything and will be removed in the next major
*/
allowUndefined?: boolean;
}

We wanted to delete the unused interface, but doing so would be a breaking change. Now that we're working on v8 it's time - let's delete the code! 🔪

Additional Info

Note that the PR for this should be targeted against the v8 branch.

💖
@JoshuaKGoldberg JoshuaKGoldberg added enhancement New feature or request good first issue Good for newcomers breaking change This change will require a new major version to be released accepting prs Go ahead, send a pull request that resolves this issue labels Apr 15, 2024
@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Apr 15, 2024
@thuchede thuchede mentioned this issue Apr 16, 2024
Merged
3 tasks
@JoshuaKGoldberg
Copy link
Member Author

#8934 was merged into v8. ✅

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2024
@bradzacher bradzacher added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Apr 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue breaking change This change will require a new major version to be released enhancement New feature or request good first issue Good for newcomers locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing.
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
2 participants
@JoshuaKGoldberg @bradzacher