Skip to content

Repo: Test rule-tester in CI #9005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JoshuaKGoldberg opened this issue Apr 26, 2024 · 1 comment · Fixed by #9919
Closed

Repo: Test rule-tester in CI #9005

JoshuaKGoldberg opened this issue Apr 26, 2024 · 1 comment · Fixed by #9919
Labels
accepting prs Go ahead, send a pull request that resolves this issue locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs

Comments

@JoshuaKGoldberg
Copy link
Member

Suggestion

Splitting out from @auvred's #8995 (comment):

Oh, looks like rule-tester is not tested in CI:

typescript-eslint/.github/workflows/ci.yml

Lines 168 to 182 in 4858afd

package:
[
'ast-spec',
'eslint-plugin',
'eslint-plugin-internal',
'parser',
'repo-tools',
'rule-schema-to-typescript-types',
'scope-manager',
'type-utils',
'typescript-eslint',
'typescript-estree',
'utils',
'visitor-keys',
]

Whoops! We should... definitely test this in CI, I'd think?

Co-authored-by: @auvred
@JoshuaKGoldberg JoshuaKGoldberg added triage Waiting for team members to take a look repo maintenance things to do with maintenance of the repo, and not with code/docs labels Apr 26, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Apr 26, 2024
Merged
3 tasks
@auvred auvred mentioned this issue Apr 27, 2024
Closed
@auvred
Copy link
Member

auvred commented Apr 27, 2024 •
edited
Loading

Note: we should run both test and test-eslint-base scripts.

Because for test-eslint-base the different test runner is used (Mocha instead of Jest). This is done so because tests/eslint-base/eslint-base.test.js is copied from upstream.

See also #9011

@JoshuaKGoldberg JoshuaKGoldberg added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for team members to take a look labels May 14, 2024
@auvred auvred mentioned this issue Aug 6, 2024
Closed
4 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Sep 3, 2024
Merged
3 tasks
@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Sep 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepting prs Go ahead, send a pull request that resolves this issue locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: also test rule-tester in CI JoshuaKGoldberg/typescript-eslint
2 participants
@JoshuaKGoldberg @auvred