Skip to content

chore: also test rule-tester in CI #9919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Adds rule-tester to the list of tested packages in CI.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Sep 3, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit af13ea8
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66d68fd2fabff20008800731
😎 Deploy Preview https://deploy-preview-9919--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 95 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Sep 3, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit af13ea8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.03%. Comparing base (5d9f49c) to head (af13ea8).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9919      +/-   ##
==========================================
- Coverage   88.12%   86.03%   -2.09%     
==========================================
  Files         406      425      +19     
  Lines       13951    14791     +840     
  Branches     4076     4302     +226     
==========================================
+ Hits        12294    12726     +432     
- Misses       1344     1718     +374     
- Partials      313      347      +34     
Flag Coverage Δ
unittest 86.03% <ø> (-2.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 19 files with indirect coverage changes

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how has this been missed for so long?!!?!?!?

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Sep 3, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 7ab7f00 into typescript-eslint:main Sep 6, 2024
64 of 65 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the test-rule-tester-ci branch September 6, 2024 13:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: Test rule-tester in CI
2 participants