Skip to content

Try out v8 beta on various influential community repos #9141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshuaKGoldberg opened this issue May 26, 2024 · 9 comments
Closed

Try out v8 beta on various influential community repos #9141

JoshuaKGoldberg opened this issue May 26, 2024 · 9 comments
Assignees
Labels
locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. meta meta-issues which consolidate many issues together team assigned A member of the typescript-eslint team should work on this.
Milestone

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented May 26, 2024

V8 is ready for public testing (hooray! https://typescript-eslint.io/blog/announcing-typescript-eslint-v8-beta 🎉) and we want to make sure we try it out on lots of projects. It'd be particularly valuable to try out projects that are:

  • Large enough to exercise test cases (think >100 source files)
  • Popular enough to get visibility for the v8 beta in front of many people (think >1000 GH stars)

I'm thinking to start, at least:

Projects we've tentatively omitted from this list

If you think any of these should be added to the list, let us know!
We're happy to learn we were wrong to omit one.

  • TypeScript: Doesn't use typed linting, and it'd be hard to get checker.ts going with it...
  • Vitest: doesn't directly use typescript-eslint

For each of these projects, we should see:

Filing this tracking issue to make sure we do this before releasing v8 as stable.

If you've got a project that matches those criteria & want to get it added to the list, let us know! We'd be happy to work with you.

For reference, v6's equivalent beta issue: #6760

@benmccann
Copy link
Contributor

benmccann commented May 28, 2024

I just tested against SvelteKit successfully:

  • pnpm create svelte@6.1.0 myapp
  • Select "Yes, using TypeScript syntax" and "Add ESLint for code linting"
  • Change the typescript-eslint version to 8.0.0-alpha.20
  • pnpm install
  • pnpm lint

This uses eslint 9, the new configs, etc. We had rolled out eslint 9 support (in create-svelte version 6.1.0, which is why the steps above use that version) and then had to rollback since typescript-eslint didn't support it yet. I'm eager for a final release of typescript-eslint so that we can move back to eslint 9 again. Is there a list of blocking issues or is the timeline for a final release calendar-based instead?

Thanks for all your work on this!

@JoshuaKGoldberg
Copy link
Member Author

Ah! That's fantastic, thanks @benmccann! You beat us to it very nicely. 😄

move back to eslint 9 again

If you're up for it, you could keep on the v8 beta. It's behaviorally stable. The only pending "breaking" changes are those noted with a ⏳ in https://typescript-eslint.io/blog/announcing-typescript-eslint-v8-beta, none of which should more than trivially impact your end-user experience.

The biggest risk is of the preset shared configs changing which rules are enabled by default - which you can always disable in your eslint.config.* / with inline comments upon switching versions.

list of blocking issues ... calendar-based

It's both.

So the earliest it would likely be released is ~July, and the latest we'd be happy with is ~September.

@JoshuaKGoldberg JoshuaKGoldberg added the meta meta-issues which consolidate many issues together label May 28, 2024
@benmccann
Copy link
Contributor

Thanks for all the details. I just released a new version of create-svelte, so anyone who sets up a new SvelteKit project with both TypeScript and eslint will use typescript-eslint version ^8.0.0-alpha.20

@JoshuaKGoldberg
Copy link
Member Author

JoshuaKGoldberg commented May 31, 2024

Note that I'm waiting on #9102 to land before taking action on this myself.

@JoshuaKGoldberg JoshuaKGoldberg added the team assigned A member of the typescript-eslint team should work on this. label Jun 2, 2024
@fisker
Copy link
Contributor

fisker commented Jun 4, 2024

Prettier is ready, sir!

@fisker
Copy link
Contributor

fisker commented Jun 4, 2024

BTW, maybe we should also mention #8920 in https://typescript-eslint.io/blog/announcing-typescript-eslint-v8-beta/ somewhere?

@romainmenke
Copy link

Also updated to v8 in @csstools : csstools/postcss-plugins#1412

postcss-preset-env and all postcss plugins, parsers, ... are using this latest version now.

@JoshuaKGoldberg
Copy link
Member Author

The checklist in the OP is full of created PRs and discovered issues have been filed on our end. We're gearing up for the v8 release Soon ™️ (🤞) so I'll close this issue out.

THANK YOU to everyone who participated on this thread and/or the PRs! We really appreciate it! ❤️

@JoshuaKGoldberg JoshuaKGoldberg unpinned this issue Jul 25, 2024
@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Jul 27, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2024
@JoshuaKGoldberg
Copy link
Member Author

For visibility: now that v8 is released, I'll go through and update the draft PRs I'd sent over the next couple of days.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. meta meta-issues which consolidate many issues together team assigned A member of the typescript-eslint team should work on this.
Projects
None yet
Development

No branches or pull requests

4 participants