refactor(typescript-estree): correct warnings reported by sonarlint #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
commented
Jan 21, 2019
| @@ -11,11 +11,11 @@ import { convertTokens } from './node-utils'; | |||
| import ts from 'typescript'; | |||
| import { Extra } from './temp-types-based-on-js-source'; | |||
|
|
|||
| export default ( | |||
| export default function astConverter ( | |||
There was a problem hiding this comment.
its easier to profile named functions
|
Codecov doesn't like my change (even if it's just refactoring) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@armano2 loggerFn is needed - prettier and some others use it |
|
ohh, i used bad wording, there is no tests if it's actually working |
JamesHenry
approved these changes
Jan 21, 2019
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
==========================================
+ Coverage 94.83% 94.99% +0.15%
==========================================
Files 48 48
Lines 2480 2479 -1
Branches 381 381
==========================================
+ Hits 2352 2355 +3
+ Misses 77 75 -2
+ Partials 51 49 -2
|
armanio123
pushed a commit
to armanio123/typescript-eslint
that referenced
this pull request
Jan 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues found in code by static code analysis by SonarLint.