feat(eslint-plugin): [consistent-type-exports] check export * exports to see if all exported members are types
#10006
Conversation
…ts to see if all exported members are types
|
Thanks for the PR, @auvred! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 5250bd8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10006 +/- ##
=======================================
Coverage 88.68% 88.69%
=======================================
Files 425 426 +1
Lines 14808 14838 +30
Branches 4307 4320 +13
=======================================
+ Hits 13132 13160 +28
- Misses 1533 1535 +2
Partials 143 143
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| // Therefore, to filter out value properties, we use the following hack: | ||
| // checker.getPropertiesOfType returns all exports that were originally | ||
| // values, but checker.getPropertyOfType returns undefined for | ||
| // properties that are mentioned in the typeOnlyExportStarMap. |
There was a problem hiding this comment.
[Praise] Lovely. Nice investigation and very helpful comment! 🙂
|
Is Typescript 4 still supported on this project? This change introduces a dependency on typescript 5.0, which breaks Typescript 4 scripts that are running eslint via the Node.JS API. |
|
@monodop hmmmm. TS 4 should still be supported. Build tooling should be transpiling into |
|
@JoshuaKGoldberg I think the easiest way to see the issue is to just look at the dist output. e.g. https://www.npmjs.com/package/@typescript-eslint/scope-manager?activeTab=code
|
|
Uh oh! @monodop, the image you shared is missing helpful alt text. Check #10006 (comment). Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs.
|
PR Checklist
Overview