Skip to content

fix(types): add NewExpression as a parent of SpreadElement #10024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix(types): add NewExpression as a parent of SpreadElement #10024

merged 1 commit into from
Sep 19, 2024

Conversation

eventualbuddha
Copy link
Contributor

new expressions may contain a spread, e.g. new Array(...[]).

PR Checklist

Overview

Adds TSESTree.NewExpression as an allowed parent type of SpreadElement, since SpreadElement can contain NewExpressions. This regressed in #9560.

@eventualbuddha
fix(types): add NewExpression as a parent of SpreadElement
190d107 
`new` expressions may contain a spread, e.g. `new Array(...[])`.
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @eventualbuddha!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Sep 19, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 190d107
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66ecb20da8fd1500086f8f25
😎 Deploy Preview https://deploy-preview-10024--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 91 (🔴 down 4 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 19, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 190d107. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

bradzacher
bradzacher approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bradzacher bradzacher merged commit c249c2f into typescript-eslint:main Sep 19, 2024
59 of 60 checks passed
@eventualbuddha eventualbuddha deleted the patch-1 branch September 19, 2024 23:52
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: SpreadElement does not allow NewExpression parent
2 participants
@eventualbuddha @bradzacher