Skip to content

docs: [strict-boolean-expressions] fix adominition #10033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 21, 2024

Conversation

kirkwaiblinger
Copy link
Member

PR Checklist

Overview

See https://typescript-eslint.io/rules/strict-boolean-expressions/#allowruletorunwithoutstrictnullchecksiknowwhatiamdoing 😬

screnshot of problem

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Sep 21, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit dbfc5f4
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66ef2cee7df9d40008907328
😎 Deploy Preview https://deploy-preview-10033--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 98 (🟢 up 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@kirkwaiblinger kirkwaiblinger requested a review from a team September 21, 2024 17:14
Copy link

nx-cloud bot commented Sep 21, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit dbfc5f4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Josh-Cena
Josh-Cena previously approved these changes Sep 21, 2024
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...Ooops!

@Josh-Cena Josh-Cena merged commit 7b149b9 into typescript-eslint:main Sep 21, 2024
60 of 62 checks passed
@kirkwaiblinger kirkwaiblinger deleted the fix-sbe-admonition branch September 21, 2024 22:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants