Skip to content

feat(eslint-plugin): Support abstract members in member-ordering rule (#395) #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 16, 2019
Merged

feat(eslint-plugin): Support abstract members in member-ordering rule (#395) #1004

merged 8 commits into from
Oct 16, 2019

Conversation

hsmitty93
Copy link
Contributor

@hsmitty93 hsmitty93 commented Sep 24, 2019 •
edited by bradzacher
Loading

Fixes #395

Member-ordering rule before had no implementation for abstract members and were treating them as private. These changes support abstract members with 'abstract' being used as another scope.

Default order with abstract members is below the scopes 'static' and 'instance'

  • Doc has been updated
  • Tests passed including added Tests

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @hsmitty93!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@hsmitty93 hsmitty93 marked this pull request as ready for review September 24, 2019 00:36
@codecov
Copy link

codecov bot commented Sep 24, 2019 •
edited
Loading

Codecov Report

Merging #1004 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1004      +/-   ##
==========================================
+ Coverage   94.06%   94.06%   +<.01%     
==========================================
  Files         115      115              
  Lines        5086     5089       +3     
  Branches     1423     1426       +3     
==========================================
+ Hits         4784     4787       +3     
  Misses        174      174              
  Partials      128      128
Impacted Files Coverage Δ
packages/eslint-plugin/src/util/misc.ts 88% <ø> (ø) ⬆️
...ackages/eslint-plugin/src/rules/member-ordering.ts 97.33% <100%> (+0.11%) ⬆️

@hsmitty93 hsmitty93 mentioned this pull request Sep 24, 2019
Closed
@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Sep 24, 2019
@hsmitty93
Copy link
Contributor Author

hsmitty93 commented Sep 24, 2019 •
edited
Loading

Will add more Unit tests to increase coverage

  • Increase code coverage

@bradzacher bradzacher mentioned this pull request Sep 27, 2019
Merged
@typescript-eslint typescript-eslint deleted a comment Oct 9, 2019
bradzacher
bradzacher approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

@JamesHenry JamesHenry merged commit 5f093ac into typescript-eslint:master Oct 16, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

@uniqueiniquity uniqueiniquity uniqueiniquity approved these changes

Assignees
No one assigned
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[member-ordering] support abstract methods
4 participants
@hsmitty93 @bradzacher @uniqueiniquity @JamesHenry