fix(eslint-plugin): [no-unnecessary-template-expression] should underline template syntax with squiggly lines #10044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @ronami! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
no-unnecessary-template-expression to include template syntax with squiggly linesno-unnecessary-template-expression to include template syntax with squiggly lines
no-unnecessary-template-expression to include template syntax with squiggly linesno-unnecessary-template-expression should underline template syntax with squiggly lines
no-unnecessary-template-expression should underline template syntax with squiggly linesno-unnecessary-template-expression should underline template syntax with squiggly lines
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10044 +/- ##
=======================================
Coverage 88.73% 88.74%
=======================================
Files 426 427 +1
Lines 14881 14886 +5
Branches 4327 4327
=======================================
+ Hits 13205 13210 +5
Misses 1534 1534
Partials 142 142
Flags with carried forward coverage won't be shown. Click here to find out more.
|
no-unnecessary-template-expression should underline template syntax with squiggly lines
kirkwaiblinger
previously approved these changes
Sep 23, 2024
packages/eslint-plugin/src/rules/no-unnecessary-template-expression.ts
Outdated
Show resolved
Hide resolved
…ssion.ts Co-authored-by: Kirk Waiblinger <kirk.waiblinger@gmail.com>
904386f
packages/eslint-plugin/src/rules/no-unnecessary-template-expression.ts
Outdated
Show resolved
Hide resolved
…ssion.ts Co-authored-by: Kirk Waiblinger <kirk.waiblinger@gmail.com>
kirkwaiblinger
approved these changes
Sep 23, 2024
6dbf234
into
typescript-eslint:main
58 of 60 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
This PR addresses #8597 and changes the squiggles marked by
@typescript-eslint/no-unnecessary-template-expressionfrom the following:To also include the template syntax instead: