Skip to content

test(type-utils): add tests for getDeclaration #10074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

YuyaYoshioka
Copy link
Contributor

@YuyaYoshioka YuyaYoshioka commented Sep 29, 2024

PR Checklist

Overview

Added tests for getDeclaration function.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @YuyaYoshioka!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Sep 29, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 14db76c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67093c5fe52a430008c99d45
😎 Deploy Preview https://deploy-preview-10074--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Sep 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 14db76c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.13%. Comparing base (94c5484) to head (14db76c).
Report is 47 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10074      +/-   ##
==========================================
+ Coverage   86.01%   86.13%   +0.11%     
==========================================
  Files         427      428       +1     
  Lines       14892    14969      +77     
  Branches     4329     4343      +14     
==========================================
+ Hits        12810    12894      +84     
+ Misses       1736     1728       -8     
- Partials      346      347       +1     
Flag Coverage Δ
unittest 86.13% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 303 files with indirect coverage changes

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, but a little hard to read - suggesting a small set of refactors?

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Oct 10, 2024
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Oct 11, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆒

@JoshuaKGoldberg JoshuaKGoldberg merged commit f153eb1 into typescript-eslint:main Oct 14, 2024
63 checks passed
@YuyaYoshioka YuyaYoshioka deleted the 8358-getDeclaration branch October 15, 2024 06:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants