Skip to content

fix(typescript-eslint): add eslint as peer dependency #10079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(typescript-eslint): add eslint as peer dependency #10079

wants to merge 1 commit into from

Conversation

rtritto
Copy link
Contributor

@rtritto rtritto commented Sep 30, 2024 •
edited
Loading

PR Checklist

Overview

eslint versions in /typescript-eslint/package.json are related to eslint versions of /@typescript-eslint/eslint-plugin/package.json

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @rtritto!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Sep 30, 2024 •
edited
Loading

❌ Deploy Preview for typescript-eslint failed.

Name Link
🔨 Latest commit a727a46
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66fb258a06e6090008f49819

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Sep 30, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a727a46. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@bradzacher
Copy link
Member

Duplicate of #9744

@bradzacher bradzacher marked this as a duplicate of #9744 Sep 30, 2024
@bradzacher bradzacher closed this Sep 30, 2024
@rtritto rtritto deleted the fix-missing-eslint-peer-dep branch September 30, 2024 22:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [typescript-eslint] missing eslint transitive peer dependency
2 participants
@rtritto @bradzacher