Skip to content

fix(typescript-eslint): propagate name field to extended configs in config helper #10094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2024
Merged

fix(typescript-eslint): propagate name field to extended configs in config helper #10094

merged 2 commits into from
Oct 15, 2024

Conversation

auvred
Copy link
Member

@auvred auvred commented Oct 3, 2024

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Oct 3, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 97f2dbf
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/670b9604613d8300084a4e69
😎 Deploy Preview https://deploy-preview-10094--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Oct 3, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 97f2dbf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Oct 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.09%. Comparing base (2055cfb) to head (97f2dbf).
Report is 41 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10094      +/-   ##
==========================================
+ Coverage   86.03%   86.09%   +0.06%     
==========================================
  Files         428      428              
  Lines       14930    14970      +40     
  Branches     4329     4344      +15     
==========================================
+ Hits        12845    12889      +44     
+ Misses       1741     1734       -7     
- Partials      344      347       +3
Flag Coverage Δ
unittest 86.09% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/typescript-eslint/src/config-helper.ts 100.00% <100.00%> (ø)

... and 296 files with indirect coverage changes

kirkwaiblinger
kirkwaiblinger previously approved these changes Oct 3, 2024
View reviewed changes
@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 3, 2024
@kirkwaiblinger kirkwaiblinger added the awaiting response Issues waiting for a reply from the OP or another party label Oct 10, 2024
@JoshuaKGoldberg JoshuaKGoldberg removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 10, 2024
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Oct 13, 2024
bradzacher
bradzacher approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks!

@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 15, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit be5bc0f into typescript-eslint:main Oct 15, 2024
64 of 66 checks passed
@ntnyq
Copy link
Contributor

ntnyq commented Oct 18, 2024

ESLint officially recommended using / as the config name separator.

Refs:

Would you mind to change __ to / or make it configurable or left it to be.

@mstykow mstykow mentioned this pull request Oct 19, 2024
Closed
4 tasks
@JoshuaKGoldberg
Copy link
Member

Oh, TIL. Yes that'd probably be good - up for filing an issue @ntnyq? 🙂

@ntnyq ntnyq mentioned this pull request Oct 20, 2024
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

@kirkwaiblinger kirkwaiblinger Awaiting requested review from kirkwaiblinger

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: The name value is not propagated in the extended configs
5 participants
@auvred @ntnyq @JoshuaKGoldberg @bradzacher @kirkwaiblinger