Skip to content

fix(typescript-estree): fix crash when running from a node --eval script #10098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2024
Merged

fix(typescript-estree): fix crash when running from a node --eval script #10098

merged 2 commits into from
Oct 3, 2024

Conversation

bradzacher
Copy link
Member

PR Checklist

Overview

I just ran into this at work.
Our codebase runs ESLint via a script that is eval'd.
So we run node --eval "code goes here"
In this instance process.argv.length === 1 -- so our single run infer code crashes!

@bradzacher bradzacher added the bug Something isn't working label Oct 3, 2024
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Oct 3, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 629a89f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66fea61f59ec2700089c8815
😎 Deploy Preview https://deploy-preview-10098--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 82 (🔴 down 14 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Oct 3, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 629a89f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Oct 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.03%. Comparing base (2055cfb) to head (629a89f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10098   +/-   ##
=======================================
  Coverage   86.03%   86.03%           
=======================================
  Files         428      428           
  Lines       14930    14930           
  Branches     4329     4330    +1     
=======================================
  Hits        12845    12845           
  Misses       1741     1741           
  Partials      344      344
Flag Coverage Δ
unittest 86.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...escript-estree/src/parseSettings/inferSingleRun.ts 100.00% <100.00%> (ø)

@bradzacher bradzacher merged commit ff80d04 into main Oct 3, 2024
62 checks passed
@bradzacher bradzacher deleted the bradzacher-patch-20241003 branch October 3, 2024 21:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradzacher @kirkwaiblinger