Skip to content

test(type-utils): add tests for getConstrainedTypeAtLocation #10108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

YuyaYoshioka
Copy link
Contributor

PR Checklist

Overview

Added tests for getConstrainedTypeAtLocation function.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @YuyaYoshioka!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Oct 6, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 1c5b1d6
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/670e8c3f56934f00087da915
😎 Deploy Preview https://deploy-preview-10108--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.20%. Comparing base (e4e8f4e) to head (1c5b1d6).
Report is 53 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10108      +/-   ##
==========================================
+ Coverage   86.07%   86.20%   +0.13%     
==========================================
  Files         428      428              
  Lines       14935    14989      +54     
  Branches     4331     4345      +14     
==========================================
+ Hits        12855    12922      +67     
+ Misses       1735     1721      -14     
- Partials      345      346       +1     
Flag Coverage Δ
unittest 86.20% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 298 files with indirect coverage changes

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same suggestion as #10074 please 😇

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Oct 10, 2024
@YuyaYoshioka
Copy link
Contributor Author

Thanks for your review! I fixed in 1c5b1d6 .
However, if you think this test is not necessary, feel free to close this PR 🙏 ref: #8358

@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Oct 15, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go for it 🙂 thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 454a33c into typescript-eslint:main Oct 21, 2024
62 of 63 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants