chore: update to nx 20 #10128
chore: update to nx 20 #10128
Conversation
|
Thanks for the PR, @JamesHenry! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -3,7 +3,6 @@ | |||
| "nxCloudAccessToken": "YjIzMmMxMWItMjhiMS00NWY2LTk1NWYtYWU3YWQ0YjE4YjBlfHJlYWQ=", | |||
| "release": { | |||
| "projects": [ | |||
| "*", | |||
There was a problem hiding this comment.
This is no longer needed, we can use a list of only negative matchers and the ALL EXCEPT is implied
☁️ Nx Cloud ReportCI is running/has finished running commands for commit e8b724e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
|
|
||
| // Append our custom messaging to the generated changelog entry | ||
| return `${defaultChangelog}\n\nYou can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.`; | ||
| module.exports = class CustomChangelogRenderer extends ( |
There was a problem hiding this comment.
The changelog renderer API is now class based where individual elements of the render can be easily patched by overwriting base methods. In our case we are just bolting text onto the full default render, so we only need to amend the main render() method.
| @@ -59,9 +59,13 @@ if (workspaceVersion === null) { | |||
| process.exit(0); | |||
| } | |||
|
|
|||
| const publishStatus = await releasePublish({ | |||
| const publishProjectsResult = await releasePublish({ | |||
There was a problem hiding this comment.
releasePublish now always returns a mapping of project names to data (which right now only contains exit codes), rather than one simplistic exit code for the whole set of projects
| @@ -1,9 +1,9 @@ | |||
| 'use strict'; | |||
|
|
|||
| // @ts-check | |||
| const { getJestProjects } = require('@nx/jest'); | |||
| const { getJestProjectsAsync } = require('@nx/jest'); | |||
There was a problem hiding this comment.
I'm getting flashbacks to C#/.NET 😛
There was a problem hiding this comment.
The sync version is only deprecated and still there so sadly we have to have another name for this one!
knip.ts
Outdated
| @@ -1,5 +1,6 @@ | |||
| import type { KnipConfig } from 'knip' with { 'resolution-mode': 'import' }; | |||
|
|
|||
| // eslint-disable-next-line import/no-default-export | |||
There was a problem hiding this comment.
Oh yeah, I fixed this in #9848 too - by just excluding knip.ts from import/no-default-export... let me merge that now.
| @@ -178,6 +178,7 @@ module.exports = config( | |||
| ); | |||
| ``` | |||
| */ | |||
| // eslint-disable-next-line import/no-default-export | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10128 +/- ##
==========================================
+ Coverage 86.09% 86.14% +0.04%
==========================================
Files 428 428
Lines 14969 14981 +12
Branches 4343 4344 +1
==========================================
+ Hits 12888 12905 +17
+ Misses 1734 1730 -4
+ Partials 347 346 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
No description provided.