feat(eslint-plugin): [no-base-to-string] add support for catching toLocaleString #10138

y-hsgw · 2024-10-12T12:32:06Z

PR Checklist

Addresses an existing open issue: fixes [no-base-to-string] doesn't catch toLocaleString #2440
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

This PR adds support for catching the toLocaleString() method.

🚀

typescript-eslint · 2024-10-12T12:32:09Z

Thanks for the PR, @y-hsgw!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2024-10-12T12:32:24Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`49de003`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6716628c741f3100089e1a88
😎 Deploy Preview	https://deploy-preview-10138--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2024-10-12T12:33:03Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 49de003. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

codecov · 2024-10-12T13:13:55Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.14%. Comparing base (ba12b14) to head (49de003).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10138   +/-   ##
=======================================
  Coverage   86.14%   86.14%           
=======================================
  Files         430      430           
  Lines       15009    15009           
  Branches     4354     4355    +1     
=======================================
  Hits        12930    12930           
  Misses       1729     1729           
  Partials      350      350

Flag	Coverage Δ
unittest	`86.14% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...kages/eslint-plugin/src/rules/no-base-to-string.ts	`95.16% <100.00%> (ø)`

packages/eslint-plugin/docs/rules/no-base-to-string.mdx

packages/eslint-plugin/tests/rules/no-base-to-string.test.ts

JoshuaKGoldberg

Oop, sorry, almost missed - some test requests?

packages/eslint-plugin/tests/rules/no-base-to-string.test.ts

packages/eslint-plugin/docs/rules/no-base-to-string.mdx

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

…github.com/y-hsgw/typescript-eslint into feature/no-base-to-string-to-locale-string

JoshuaKGoldberg

Getting there 🙂 only small things from me.

packages/eslint-plugin/docs/rules/no-base-to-string.mdx

packages/eslint-plugin/tests/rules/no-base-to-string.test.ts

JoshuaKGoldberg

(wrong button)

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>

JoshuaKGoldberg

Thanks!

@kirkwaiblinger

##### [v8.11.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8110-2024-10-21) ##### 🚀 Features - **eslint-plugin:** \[no-unnecessary-type-parameters] add suggestion fixer ([#10149](typescript-eslint/typescript-eslint#10149)) - **eslint-plugin:** \[no-base-to-string] add support for catching toLocaleString ([#10138](typescript-eslint/typescript-eslint#10138)) ##### 🩹 Fixes - **eslint-plugin:** \[class-literal-property-style] don't report nodes with `override` keyword ([#10135](typescript-eslint/typescript-eslint#10135)) ##### ❤️ Thank You - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@kirkwaiblinger

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.10.0 | 8.11.0 | | npm | @typescript-eslint/parser | 8.10.0 | 8.11.0 | ## [v8.11.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8110-2024-10-21) ##### 🚀 Features - **eslint-plugin:** \[no-unnecessary-type-parameters] add suggestion fixer ([#10149](typescript-eslint/typescript-eslint#10149)) - **eslint-plugin:** \[no-base-to-string] add support for catching toLocaleString ([#10138](typescript-eslint/typescript-eslint#10138)) ##### 🩹 Fixes - **eslint-plugin:** \[class-literal-property-style] don't report nodes with `override` keyword ([#10135](typescript-eslint/typescript-eslint#10135)) ##### ❤️ Thank You - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@kirkwaiblinger

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.10.0 | 8.11.0 | | npm | @typescript-eslint/parser | 8.10.0 | 8.11.0 | ## [v8.11.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8110-2024-10-21) ##### 🚀 Features - **eslint-plugin:** \[no-unnecessary-type-parameters] add suggestion fixer ([#10149](typescript-eslint/typescript-eslint#10149)) - **eslint-plugin:** \[no-base-to-string] add support for catching toLocaleString ([#10138](typescript-eslint/typescript-eslint#10138)) ##### 🩹 Fixes - **eslint-plugin:** \[class-literal-property-style] don't report nodes with `override` keyword ([#10135](typescript-eslint/typescript-eslint#10135)) ##### ❤️ Thank You - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - Yukihiro Hasegawa [@y-hsgw](https://github.com/y-hsgw) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

y-hsgw added 4 commits October 12, 2024 20:01

feat: add support for toLocaleString method

00754ea

test: add Tests

6ef7066

test: fix test

3e4bcff

docs: update doc

c246f0a

y-hsgw changed the title ~~feat(eslint-plugin): [no-base-to-string]add support for catching toLocaleString~~ feat(eslint-plugin): [no-base-to-string] add support for catching toLocaleString Oct 12, 2024

test: update snapshot and fix description

f37af6a

JoshuaKGoldberg reviewed Oct 14, 2024

View reviewed changes

packages/eslint-plugin/docs/rules/no-base-to-string.mdx Outdated Show resolved Hide resolved

docs: fix typo

ebc6947

kirkwaiblinger previously approved these changes Oct 14, 2024

View reviewed changes

kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 14, 2024

JoshuaKGoldberg approved these changes Oct 15, 2024

View reviewed changes

JoshuaKGoldberg reviewed Oct 15, 2024

View reviewed changes

packages/eslint-plugin/tests/rules/no-base-to-string.test.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg requested changes Oct 15, 2024

View reviewed changes

packages/eslint-plugin/tests/rules/no-base-to-string.test.ts Outdated Show resolved Hide resolved

test: fix typo and remove test

31a7cf4

FloEdelmann suggested changes Oct 15, 2024

View reviewed changes

packages/eslint-plugin/docs/rules/no-base-to-string.mdx Outdated Show resolved Hide resolved

packages/eslint-plugin/docs/rules/no-base-to-string.mdx Outdated Show resolved Hide resolved

Update packages/eslint-plugin/docs/rules/no-base-to-string.mdx

3ffe462

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

y-hsgw dismissed kirkwaiblinger’s stale review via 3ffe462 October 15, 2024 10:20

y-hsgw and others added 2 commits October 15, 2024 19:20

Update packages/eslint-plugin/docs/rules/no-base-to-string.mdx

1c49fd6

Co-authored-by: Flo Edelmann <git@flo-edelmann.de>

Merge branch 'feature/no-base-to-string-to-locale-string' of https://…

ea11e91

…github.com/y-hsgw/typescript-eslint into feature/no-base-to-string-to-locale-string

y-hsgw requested review from JoshuaKGoldberg and FloEdelmann October 15, 2024 10:25

github-actions bot removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 15, 2024

JoshuaKGoldberg approved these changes Oct 15, 2024

View reviewed changes

packages/eslint-plugin/docs/rules/no-base-to-string.mdx Outdated Show resolved Hide resolved

packages/eslint-plugin/tests/rules/no-base-to-string.test.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg requested changes Oct 15, 2024

View reviewed changes

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Oct 15, 2024

no-base-to-string.mdx を更新

379dba6

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>

Update packages/eslint-plugin/tests/rules/no-base-to-string.test.ts

b4c7216

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>

y-hsgw requested a review from JoshuaKGoldberg October 15, 2024 14:46

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Oct 15, 2024

JoshuaKGoldberg previously approved these changes Oct 15, 2024

View reviewed changes

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 15, 2024

Merge branch 'main'

49de003

JoshuaKGoldberg dismissed their stale review via 49de003 October 21, 2024 14:17

JoshuaKGoldberg merged commit 9a182d0 into typescript-eslint:main Oct 21, 2024
60 checks passed

y-hsgw deleted the feature/no-base-to-string-to-locale-string branch October 21, 2024 15:44

github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eslint-plugin): [no-base-to-string] add support for catching toLocaleString #10138

feat(eslint-plugin): [no-base-to-string] add support for catching toLocaleString #10138

y-hsgw commented Oct 12, 2024 •

edited

Loading

typescript-eslint bot commented Oct 12, 2024

netlify bot commented Oct 12, 2024 •

edited

Loading

nx-cloud bot commented Oct 12, 2024 •

edited

Loading

codecov bot commented Oct 12, 2024 •

edited

Loading

JoshuaKGoldberg left a comment

JoshuaKGoldberg left a comment

JoshuaKGoldberg left a comment

JoshuaKGoldberg left a comment

feat(eslint-plugin): [no-base-to-string] add support for catching toLocaleString #10138

feat(eslint-plugin): [no-base-to-string] add support for catching toLocaleString #10138

Conversation

y-hsgw commented Oct 12, 2024 • edited Loading

PR Checklist

Overview

typescript-eslint bot commented Oct 12, 2024

netlify bot commented Oct 12, 2024 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

nx-cloud bot commented Oct 12, 2024 • edited Loading

☁️ Nx Cloud Report

codecov bot commented Oct 12, 2024 • edited Loading

Codecov Report

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

y-hsgw commented Oct 12, 2024 •

edited

Loading

netlify bot commented Oct 12, 2024 •

edited

Loading

nx-cloud bot commented Oct 12, 2024 •

edited

Loading

codecov bot commented Oct 12, 2024 •

edited

Loading