Skip to content

chore: coverage issues caused by using export assignments #10151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2024
Merged

chore: coverage issues caused by using export assignments #10151

merged 1 commit into from
Oct 18, 2024

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

Change coveragePathIgnorePatterns to modulePathIgnorePatterns to fix #10146.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Oct 15, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 3050e3a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6712135f5f6ce1000851058f
😎 Deploy Preview https://deploy-preview-10151--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 94 (🔴 down 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Oct 15, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3050e3a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.14%. Comparing base (bab0d65) to head (3050e3a).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10151      +/-   ##
==========================================
- Coverage   86.15%   86.14%   -0.01%     
==========================================
  Files         429      430       +1     
  Lines       15005    15009       +4     
  Branches     4353     4354       +1     
==========================================
+ Hits        12927    12930       +3     
  Misses       1729     1729              
- Partials      349      350       +1
Flag Coverage Δ
unittest 86.14% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@bradzacher bradzacher changed the title fix: coverage issues caused by using export assignments chore: coverage issues caused by using export assignments Oct 15, 2024
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🧹

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 15, 2024
@aryaemami59 aryaemami59 force-pushed the fix-coverage-issue branch 2 times, most recently from 7a69d1c to 2ce4408 Compare October 15, 2024 21:55
@aryaemami59
Copy link
Contributor Author

hmmm... I wonder if I should do the same in packages/eslint-plugin-internal/jest.config.js.

@aryaemami59 aryaemami59 force-pushed the fix-coverage-issue branch 2 times, most recently from c391074 to 2374d38 Compare October 16, 2024 21:41
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@JoshuaKGoldberg JoshuaKGoldberg merged commit 127066a into typescript-eslint:main Oct 18, 2024
62 checks passed
@aryaemami59 aryaemami59 deleted the fix-coverage-issue branch October 18, 2024 14:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: 'Export assignment cannot be used' log errors in Jest tests
2 participants
@aryaemami59 @JoshuaKGoldberg