Skip to content

feat(eslint-plugin): [thenable-in-promise-aggregators] add rule #10163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

feat(eslint-plugin): [thenable-in-promise-aggregators] add rule #10163

wants to merge 30 commits into from

Conversation

abrahamguo
Copy link
Contributor

PR Checklist

Overview

Resurrection of @Tjstretchalot's work in #8094 .

@Tjstretchalot
feat(eslint-plugin): [thenable-in-promise-aggregators] resolve typesc…
5302e72 
…ript-eslint#1804
@Tjstretchalot
Working tests/spelling/lint
3c79e83
@Tjstretchalot
Remove accidental linebreak mid-sentence
ac00bbf
@Tjstretchalot
Remove from recommended
453b5c3
@Tjstretchalot
Support Promise aliases
c2a10e2
@Tjstretchalot
Support tuple args
e3e2a4a
@Tjstretchalot
Handle empty arrays / omitted elements in array
056dfe1
@Tjstretchalot
Assert impossible missing type args
03c4fc9
@Tjstretchalot
Test array of any/unknown in valid
00909d3
@Tjstretchalot
Remove unnecessary suggestions line
da403ff
@Tjstretchalot
yarn lint --fix
fada233
@Tjstretchalot
Remove unnecessary aliasing on messageId
d918f42
@Tjstretchalot
Split dual-purpose test cases
9859e6d
@Tjstretchalot
Tests for [] syntax instead of dot syntax
2cfbf76
@Tjstretchalot
Explicit tests for union types
3e0e442
@Tjstretchalot
Use shorter valid testcase syntax
20e1545
@Tjstretchalot
Fix including = in declare const
7a3cc01
@Tjstretchalot
Use latest helpers from typescript-eslint#8011
304356e
@Tjstretchalot
Carefully handle complicated promise-likes, remove nonArrayArg
d58111d
@Tjstretchalot
Rename callerType calleeType for consistency
609db97
@Tjstretchalot
Add any to list of promise aggregators
698e579
@Tjstretchalot
Update to pull in type util functions
4028718
@Tjstretchalot
emptyArrayElement, refactoring, typed member names
82447b7 
Also adds tests for rejected promises, calling via template literals, and `never` argument values
@Tjstretchalot
Minor documentation cleanup
c5aef50
@Tjstretchalot
Avoid backward incompat lib signature change
2bbe8fa
@Tjstretchalot
Satisfy linter
ea65212
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Oct 17, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 15f08c2
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6711064d36030b000834aae5
😎 Deploy Preview https://deploy-preview-10163--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🟢 up 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Oct 17, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 15f08c2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

🟥 Failed Commands
nx test eslint-plugin --coverage=false
nx run-many --target=lint --exclude eslint-plugin
nx test typescript-eslint --coverage=false
✅ Successfully ran 16 targets

Sent with 💌 from NxCloud.

@kirkwaiblinger
Copy link
Member

Hi, just leaving a quick comment, no time for a review, but now that this is being revisited I think we should use this opportunity to incorporate it into await-thenable. See #8094 (review), #8858 (comment).

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Nov 4, 2024 •
edited
Loading

Marking as draft pending being changed up per #10163 (comment). cc @abrahamguo 👋

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft November 4, 2024 16:18
@kirkwaiblinger kirkwaiblinger mentioned this pull request Nov 11, 2024
Closed
3 tasks
@JoshuaKGoldberg
Copy link
Member

@abrahamguo @kirkwaiblinger just checking in, what should be done here?

@kirkwaiblinger
Copy link
Member

Well, #10282 was also attempting to tackle this but went stale... I'd say - if you want to continue this @abrahamguo then go for it! Otherwise if there isn't activity on this for a bit we may want to close it out as stale as well until someone has bandwidth to carry the torch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@abrahamguo @kirkwaiblinger @JoshuaKGoldberg @Tjstretchalot