Skip to content

chore: enable eslint-plugin-perfectionist on the rest of the repo #10189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 4, 2024
Merged

chore: enable eslint-plugin-perfectionist on the rest of the repo #10189

merged 6 commits into from
Nov 4, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Oct 21, 2024 •
edited
Loading

PR Checklist

Overview

Completely replaces the simple-import-sort plugin with perfectionist, and enables it as a baseline in all remaining files.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Oct 21, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 5cab80b
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6728d332f0924e00084f76d2
😎 Deploy Preview https://deploy-preview-10189--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 92 (🔴 down 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Oct 21, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5cab80b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 30 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.50%. Comparing base (3664c20) to head (5cab80b).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10189   +/-   ##
=======================================
  Coverage   86.50%   86.50%           
=======================================
  Files         430      430           
  Lines       15118    15121    +3     
  Branches     4396     4397    +1     
=======================================
+ Hits        13078    13081    +3     
  Misses       1683     1683           
  Partials      357      357
Flag Coverage Δ
unittest 86.50% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...gin-internal/src/rules/no-poorly-typed-ts-props.ts 95.45% <ø> (ø)
...rc/rules/no-relative-paths-to-internal-packages.ts 100.00% <ø> (ø)
...internal/src/rules/no-typescript-default-import.ts 86.66% <ø> (ø)
...-internal/src/rules/no-typescript-estree-import.ts 87.50% <ø> (ø)
...lugin-internal/src/rules/plugin-test-formatting.ts 82.79% <ø> (ø)
...plugin-internal/src/rules/prefer-ast-types-enum.ts 100.00% <100.00%> (ø)
packages/scope-manager/src/lib/es2015.core.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/es2015.iterable.ts 100.00% <ø> (ø)
...s/scope-manager/src/lib/es2015.symbol.wellknown.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/es2015.ts 100.00% <100.00%> (ø)
... and 7 more

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review October 23, 2024 22:40
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team October 23, 2024 22:40
bradzacher
bradzacher previously approved these changes Nov 3, 2024
View reviewed changes
@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 3, 2024
@JoshuaKGoldberg
Copy link
Member Author

I'm tired of dealing with merge conflicts 🙃. Merging now. YOLO.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 3b97b55 into typescript-eslint:main Nov 4, 2024
9 of 10 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the perfectionist-remaining branch November 4, 2024 14:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher left review comments

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Enable alphabetical (natural) sorting of fields
2 participants
@JoshuaKGoldberg @bradzacher