Skip to content

docs: enable respectPrefersColorScheme #10246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

hyoban
Copy link
Contributor

@hyoban hyoban commented Oct 31, 2024

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @hyoban!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit e0d1a92
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67269f636078650008ae5238
😎 Deploy Preview https://deploy-preview-10246--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Oct 31, 2024

@kirkwaiblinger
Copy link
Member

Checked the deploy preview, and I love it! ❤️

Only thing is, it would be nice as a user to be able to select between light/dark/system, since otherwise once you switch it persists. But idk if that needs to happen in this PR. Maybe others will have opinions.

@Josh-Cena
Copy link
Member

Only thing is, it would be nice as a user to be able to select between light/dark/system, since otherwise once you switch it persists.

This is facebook/docusaurus#8074, perhaps, unless you want to spend a lot of effort to implement it all in userland.

@hyoban
Copy link
Contributor Author

hyoban commented Nov 1, 2024

Its behavior looks fine to me.

If the user's website settings are inconsistent with the system's selection, they will not be synchronized. When the user's selection returns consistent with the system, it will automatically switch following the system switch.

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 1, 2024
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.51%. Comparing base (5c3e7d7) to head (e0d1a92).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10246   +/-   ##
=======================================
  Coverage   86.51%   86.51%           
=======================================
  Files         430      430           
  Lines       15098    15098           
  Branches     4384     4384           
=======================================
  Hits        13062    13062           
  Misses       1679     1679           
  Partials      357      357           
Flag Coverage Δ
unittest 86.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Josh-Cena Josh-Cena enabled auto-merge (squash) November 2, 2024 21:54
@Josh-Cena Josh-Cena merged commit 8c6a721 into typescript-eslint:main Nov 2, 2024
59 of 60 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: enable respectPrefersColorScheme in docusaurus themeConfig
3 participants