-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
docs: enable respectPrefersColorScheme
#10246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @hyoban! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Checked the deploy preview, and I love it! ❤️ Only thing is, it would be nice as a user to be able to select between light/dark/system, since otherwise once you switch it persists. But idk if that needs to happen in this PR. Maybe others will have opinions. |
This is facebook/docusaurus#8074, perhaps, unless you want to spend a lot of effort to implement it all in userland. |
Its behavior looks fine to me. If the user's website settings are inconsistent with the system's selection, they will not be synchronized. When the user's selection returns consistent with the system, it will automatically switch following the system switch. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10246 +/- ##
=======================================
Coverage 86.51% 86.51%
=======================================
Files 430 430
Lines 15098 15098
Branches 4384 4384
=======================================
Hits 13062 13062
Misses 1679 1679
Partials 357 357
Flags with carried forward coverage won't be shown. Click here to find out more. |
PR Checklist
respectPrefersColorScheme
in docusaurusthemeConfig
#10237Overview