Skip to content

feat: add options property to ImportExpression node #10255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 3, 2024
Merged

feat: add options property to ImportExpression node #10255

merged 4 commits into from
Nov 3, 2024

Conversation

ota-meshi
Copy link
Contributor

PR Checklist

Overview

This PR adds the options property to the ImportExpression node.

I made changes to ast-spec, typescript-estree and visitor-keys.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ota-meshi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Oct 31, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f542702
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67279309c3f86b000820e446
😎 Deploy Preview https://deploy-preview-10255--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Oct 31, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f542702. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 32 targets

Sent with 💌 from NxCloud.

@ota-meshi
Copy link
Contributor Author

ota-meshi commented Oct 31, 2024 •
edited
Loading

"Deploy Preview" is failing and I don't know why... Can you give me some advice?

Solved. I fixed the missing escaping required by JSDoc.

@ota-meshi
Copy link
Contributor Author

ota-meshi commented Nov 1, 2024 •
edited
Loading

Oh, it seems CI failed too, but looking at the logs I can't figure out why 😓

Solved, it was fixed when ran it again.

@codecov Codecov
Copy link

codecov bot commented Nov 1, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.51%. Comparing base (3f34490) to head (676e283).
Report is 1 commits behind head on main.

❗ Current head 676e283 differs from pull request most recent head f542702

Please upload reports for the commit f542702 to get more accurate results.

Files with missing lines Patch % Lines
packages/typescript-estree/src/convert.ts 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10255   +/-   ##
=======================================
  Coverage   86.51%   86.51%           
=======================================
  Files         430      430           
  Lines       15123    15098   -25     
  Branches     4400     4384   -16     
=======================================
- Hits        13083    13062   -21     
+ Misses       1683     1679    -4     
  Partials      357      357
Flag Coverage Δ
unittest 86.51% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/visitor-keys/src/visitor-keys.ts 100.00% <ø> (ø)
packages/typescript-estree/src/convert.ts 28.88% <0.00%> (ø)

... and 2 files with indirect coverage changes

@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 3, 2024
@Josh-Cena Josh-Cena enabled auto-merge (squash) November 3, 2024 15:13
@Josh-Cena Josh-Cena merged commit b347c04 into typescript-eslint:main Nov 3, 2024
59 of 60 checks passed
@ota-meshi ota-meshi deleted the import-attributes branch November 3, 2024 18:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

@Josh-Cena Josh-Cena Josh-Cena approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhancement: Add the options property to ImportExpression node
3 participants
@ota-meshi @bradzacher @Josh-Cena