Skip to content

fix(eslint-plugin): [no-deprecated] report on deprecated variables used inside dynamic imports #10261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2024
Merged

fix(eslint-plugin): [no-deprecated] report on deprecated variables used inside dynamic imports #10261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/eslint-plugin/src/rules/no-deprecated.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ export default createRule({
case AST_NODE_TYPES.ExportDefaultDeclaration:
case AST_NODE_TYPES.ExportNamedDeclaration:
case AST_NODE_TYPES.ImportDeclaration:
case AST_NODE_TYPES.ImportExpression:
return true;

case AST_NODE_TYPES.ArrowFunctionExpression:
Expand Down
16 changes: 16 additions & 0 deletions packages/eslint-plugin/tests/rules/no-deprecated.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,22 @@ ruleTester.run('no-deprecated', rule, {
},
],
},
{
code: `
/** @deprecated */ const a = 'foo';
import(\`./path/\${a}.js\`);
`,
errors: [
{
column: 26,
data: { name: 'a' },
endColumn: 27,
endLine: 3,
line: 3,
messageId: 'deprecated',
},
],
},
{
code: `
declare function log(...args: unknown): void;
Expand Down
Loading