Skip to content

docs: include Bluesky profile in social links #10296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 14, 2024
Merged

docs: include Bluesky profile in social links #10296

merged 7 commits into from
Nov 14, 2024

Conversation

gyumong
Copy link
Contributor

@gyumong gyumong commented Nov 6, 2024 •
edited
Loading

PR Checklist

Overview

This pull request addresses issue #10295 by adding the Bluesky account to the typescript-eslint.io website.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @gyumong!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Nov 6, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 9a2656e
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6732cd15f520a20008a20114
😎 Deploy Preview https://deploy-preview-10296--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 94 (🔴 down 5 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 6, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9a2656e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

JoshuaKGoldberg
JoshuaKGoldberg requested changes Nov 10, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one nitpick on ordering, because I can't help myself 🙂

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Nov 10, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.59%. Comparing base (0409851) to head (9a2656e).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10296   +/-   ##
=======================================
  Coverage   86.59%   86.59%           
=======================================
  Files         432      432           
  Lines       15163    15163           
  Branches     4426     4426           
=======================================
  Hits        13131    13131           
  Misses       1675     1675           
  Partials      357      357
Flag Coverage Δ
unittest 86.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Nov 12, 2024
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugs Bunny tap-dancing. Caption: "Happy toe tapping Tuesday"

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 12, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 09d7049 into typescript-eslint:main Nov 14, 2024
63 of 65 checks passed
omril1 pushed a commit to omril1/typescript-eslint that referenced this pull request Nov 16, 2024
@gyumong
docs: include Bluesky profile in social links (typescript-eslint#10296)
ea3e06d 
* feat: add to svg

* feat: add the Bluesky

* chore: add cspell like Bluesky

* fix: icon

* fix: sort social links
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Website: Add the Bluesky account too
2 participants
@gyumong @JoshuaKGoldberg