Skip to content

feat(eslint-plugin): [prefer-nullish-coalescing] fix detection of ignoreConditionalTests involving boolean ! operator #10299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 16, 2024
Merged

feat(eslint-plugin): [prefer-nullish-coalescing] fix detection of ignoreConditionalTests involving boolean ! operator #10299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9d490f5
fix: add unaryExpression to recursive
developer-bandi Nov 7, 2024
5fcfd02
Merge branch 'main' into feature/prefer-nullish-coalescing-unaryexpre…
kirkwaiblinger Nov 7, 2024
3f16099
fix: only apply ! operator
developer-bandi Nov 8, 2024
1ddd9bf
Merge branch 'feature/prefer-nullish-coalescing-unaryexpression' of h…
developer-bandi Nov 8, 2024
707188e
feat: add same logic to boolean
developer-bandi Nov 11, 2024
24eddcf
Merge branch 'main' into feature/prefer-nullish-coalescing-unaryexpre…
developer-bandi Nov 11, 2024
6b4dbda
fix: revert ignoreBooleanCoercion option logic
developer-bandi Nov 13, 2024
8bd626d
Merge branch 'feature/prefer-nullish-coalescing-unaryexpression' of h…
developer-bandi Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,13 @@ function isConditionalTest(node: TSESTree.Node): boolean {
return isConditionalTest(parent);
}

if (
parent.type === AST_NODE_TYPES.UnaryExpression &&
parent.operator === '!'
) {
return isConditionalTest(parent);
}

if (
(parent.type === AST_NODE_TYPES.ConditionalExpression ||
parent.type === AST_NODE_TYPES.DoWhileStatement ||
Expand Down
61 changes: 60 additions & 1 deletion packages/eslint-plugin/tests/rules/prefer-nullish-coalescing.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,34 @@ let b: string | boolean | undefined;
let c: string | boolean | undefined;

if (((a = b), b || c)) {
}
`,
options: [
{
ignoreConditionalTests: true,
},
],
},
{
code: `
let a: string | undefined;
let b: string | undefined;

if (!(a || b)) {
}
`,
options: [
{
ignoreConditionalTests: true,
},
],
},
{
code: `
let a: string | undefined;
let b: string | undefined;

if (!!(a || b)) {
}
`,
options: [
Expand Down Expand Up @@ -2266,7 +2294,38 @@ if (f(a ?? b)) {
],
options: [
{
ignoreBooleanCoercion: true,
ignoreConditionalTests: true,
},
],
},
{
code: `
declare const a: string | undefined;
declare const b: string;

if (+(a || b)) {
}
`,
errors: [
{
messageId: 'preferNullishOverOr',
suggestions: [
{
messageId: 'suggestNullish',
output: `
declare const a: string | undefined;
declare const b: string;

if (+(a ?? b)) {
}
`,
},
],
},
],
options: [
{
ignoreConditionalTests: true,
},
],
},
Expand Down
Loading