feat: support TypeScript 5.7 #10372
feat: support TypeScript 5.7 #10372
Conversation
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1f6cc26. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10372 +/- ##
==========================================
+ Coverage 86.69% 86.72% +0.03%
==========================================
Files 434 443 +9
Lines 15227 15270 +43
Branches 4445 4445
==========================================
+ Hits 13201 13243 +42
- Misses 1673 1674 +1
Partials 353 353
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -71,13 +72,21 @@ type Lib = | |||
| | 'es2022.intl' | |||
| | 'es2022.object' | |||
| | 'es2022.regexp' | |||
| | 'es2022.sharedmemory' | |||
There was a problem hiding this comment.
Newest typescript might have removed this, but the plugin should be compatible with previous TS versions (as per range in package.json) and those previous versions do know what es2022.sharedmemory is. This change makes this eslint plugin incompatible with previous TS versions in projects declaring use of es2022.sharedmemory
There was a problem hiding this comment.
Interesting. Could you please file an issue with a reproduction?
There was a problem hiding this comment.
Actually, it's not this change, it's the rename of the lib file in scope-manager. Still caused by this PR
PR Checklist
Overview
Updates lib and scope definitions.
Doesn't update
project: trueto match the new ancestor configuration file searching, as that should already be covered byprojectService: true.💖