fix(eslint-plugin): [no-deprecated] check if a JSX attribute is deprecated #10374

mdm317 · 2024-11-23T07:21:06Z

PR Checklist

Addresses an existing open issue: fixes Bug: [no-deprecated] No warnings about usage of deprecated props in JSX components #10275
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Added a logic to check deprecated attributes from JSDoc when used in JSX.

typescript-eslint · 2024-11-23T07:21:09Z

Thanks for the PR, @mdm317!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2024-11-23T07:21:32Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`ae9717e`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6753f93941e10500089d8278
😎 Deploy Preview	https://deploy-preview-10374--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🟢 up 6 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2024-11-23T07:21:59Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ae9717e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

codecov · 2024-11-23T07:41:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.77%. Comparing base (0d0722c) to head (ae9717e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #10374   +/-   ##
=======================================
  Coverage   86.76%   86.77%           
=======================================
  Files         444      444           
  Lines       15313    15320    +7     
  Branches     4459     4461    +2     
=======================================
+ Hits        13287    13294    +7     
  Misses       1672     1672           
  Partials      354      354

Flag	Coverage Δ
unittest	`86.77% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/eslint-plugin/src/rules/no-deprecated.ts	`93.61% <100.00%> (+0.51%)`	⬆️

JoshuaKGoldberg

Codecov is letting us know that a couple areas of code aren't covered by unit tests. For each, one of the following is true:

The code is reachable, so a unit test should exercise it
The code can be refactored to not include that case (e.g. passing a narrowed value around instead of re-checking something)
This is some edge case in TypeScript-land and a type assertion should be used (instead of a runtime check)

I can re-review once the test coverage gaps are gone. Cheers!

packages/eslint-plugin/src/rules/no-deprecated.ts

JoshuaKGoldberg

Implementation looks great to me, very nicely done! 👏

Just requesting changes on a bit more tests, since there's the tricky nullThrows. Thanks!

packages/eslint-plugin/src/rules/no-deprecated.ts

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>

…error"

JoshuaKGoldberg

Glorious! Thank you! 🙌

@developer-bandi

##### [v8.18.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8180-2024-12-09) ##### 🚀 Features - **eslint-plugin:** \[switch-exhaustiveness-check] add support for "no default" comment ([#10218](typescript-eslint/typescript-eslint#10218)) - **eslint-plugin:** \[no-deprecated] report on super call of deprecated constructor ([#10397](typescript-eslint/typescript-eslint#10397)) ##### 🩹 Fixes - **eslint-plugin:** \[use-unknown-in-catch-callback-variable] only flag function literals ([#10436](typescript-eslint/typescript-eslint#10436)) - **eslint-plugin:** \[no-base-to-string] handle more robustly when multiple `toString()` declarations are present for a type ([#10432](typescript-eslint/typescript-eslint#10432)) - **eslint-plugin:** \[no-deprecated] check if a JSX attribute is deprecated ([#10374](typescript-eslint/typescript-eslint#10374)) - typescript peer dependency ([#10373](typescript-eslint/typescript-eslint#10373)) ##### ❤️ Thank You - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - rtritto You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@developer-bandi

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.17.0 | 8.18.0 | | npm | @typescript-eslint/parser | 8.17.0 | 8.18.0 | ## [v8.18.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8180-2024-12-09) ##### 🚀 Features - **eslint-plugin:** \[switch-exhaustiveness-check] add support for "no default" comment ([#10218](typescript-eslint/typescript-eslint#10218)) - **eslint-plugin:** \[no-deprecated] report on super call of deprecated constructor ([#10397](typescript-eslint/typescript-eslint#10397)) ##### 🩹 Fixes - **eslint-plugin:** \[use-unknown-in-catch-callback-variable] only flag function literals ([#10436](typescript-eslint/typescript-eslint#10436)) - **eslint-plugin:** \[no-base-to-string] handle more robustly when multiple `toString()` declarations are present for a type ([#10432](typescript-eslint/typescript-eslint#10432)) - **eslint-plugin:** \[no-deprecated] check if a JSX attribute is deprecated ([#10374](typescript-eslint/typescript-eslint#10374)) - typescript peer dependency ([#10373](typescript-eslint/typescript-eslint#10373)) ##### ❤️ Thank You - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - rtritto You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@developer-bandi

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.17.0 | 8.18.0 | | npm | @typescript-eslint/parser | 8.17.0 | 8.18.0 | ## [v8.18.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8180-2024-12-09) ##### 🚀 Features - **eslint-plugin:** \[switch-exhaustiveness-check] add support for "no default" comment ([#10218](typescript-eslint/typescript-eslint#10218)) - **eslint-plugin:** \[no-deprecated] report on super call of deprecated constructor ([#10397](typescript-eslint/typescript-eslint#10397)) ##### 🩹 Fixes - **eslint-plugin:** \[use-unknown-in-catch-callback-variable] only flag function literals ([#10436](typescript-eslint/typescript-eslint#10436)) - **eslint-plugin:** \[no-base-to-string] handle more robustly when multiple `toString()` declarations are present for a type ([#10432](typescript-eslint/typescript-eslint#10432)) - **eslint-plugin:** \[no-deprecated] check if a JSX attribute is deprecated ([#10374](typescript-eslint/typescript-eslint#10374)) - typescript peer dependency ([#10373](typescript-eslint/typescript-eslint#10373)) ##### ❤️ Thank You - Kim Sang Du [@developer-bandi](https://github.com/developer-bandi) - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - mdm317 - rtritto You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

mdm317 added 2 commits November 23, 2024 16:12

test : add testcase

ea6c5ec

fix : check if a JSX attribute is deprecated

a06f122

test : fix text result

ba379b4

JoshuaKGoldberg requested changes Nov 24, 2024

View reviewed changes

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Nov 24, 2024

Josh-Cena reviewed Nov 25, 2024

View reviewed changes

packages/eslint-plugin/src/rules/no-deprecated.ts Outdated Show resolved Hide resolved

mdm317 added 6 commits November 26, 2024 19:03

fix : check all jsx names

8b90666

test : add test case for all jsx name

63afd1d

Merge branch 'main' into fix/issue-10275-no-deprecated

f1c5b10

test : increase coverage

e25b6a2

fix : type assertion for test coverage

96f3b76

refactor : change variable name

3309db8

mdm317 requested a review from JoshuaKGoldberg November 29, 2024 13:56

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Nov 29, 2024

JoshuaKGoldberg requested changes Dec 2, 2024

View reviewed changes

packages/eslint-plugin/src/rules/no-deprecated.ts Outdated Show resolved Hide resolved

packages/eslint-plugin/src/rules/no-deprecated.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Dec 2, 2024

mdm317 and others added 3 commits December 7, 2024 16:09

Update packages/eslint-plugin/src/rules/no-deprecated.ts

63b00e1

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>

Merge branch 'main' into fix/issue-10275-no-deprecated

b808836

Add a test case namespace and attribute are of type "any" "unknown" "…

ae9717e

…error"

mdm317 requested a review from JoshuaKGoldberg December 7, 2024 08:28

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Dec 7, 2024

JoshuaKGoldberg approved these changes Dec 7, 2024

View reviewed changes

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Dec 7, 2024

JoshuaKGoldberg merged commit 772bd43 into typescript-eslint:main Dec 7, 2024
65 checks passed

This was referenced Dec 11, 2024

Issue: '@typescript-eslint/no-deprecated' seems broken tools-aoeur/eslint-config#13

Closed

fix: Package update including typescript deprecation checker fix tools-aoeur/eslint-config#17

Merged

github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(eslint-plugin): [no-deprecated] check if a JSX attribute is deprecated #10374

fix(eslint-plugin): [no-deprecated] check if a JSX attribute is deprecated #10374

mdm317 commented Nov 23, 2024 •

edited

Loading

typescript-eslint bot commented Nov 23, 2024

netlify bot commented Nov 23, 2024 •

edited

Loading

nx-cloud bot commented Nov 23, 2024 •

edited

Loading

codecov bot commented Nov 23, 2024 •

edited

Loading

JoshuaKGoldberg left a comment

JoshuaKGoldberg left a comment

JoshuaKGoldberg left a comment

fix(eslint-plugin): [no-deprecated] check if a JSX attribute is deprecated #10374

fix(eslint-plugin): [no-deprecated] check if a JSX attribute is deprecated #10374

Conversation

mdm317 commented Nov 23, 2024 • edited Loading

PR Checklist

Overview

typescript-eslint bot commented Nov 23, 2024

netlify bot commented Nov 23, 2024 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

nx-cloud bot commented Nov 23, 2024 • edited Loading

☁️ Nx Cloud Report

codecov bot commented Nov 23, 2024 • edited Loading

Codecov Report

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

mdm317 commented Nov 23, 2024 •

edited

Loading

netlify bot commented Nov 23, 2024 •

edited

Loading

nx-cloud bot commented Nov 23, 2024 •

edited

Loading

codecov bot commented Nov 23, 2024 •

edited

Loading