Skip to content

test(typescript-estree): add test to ensure TS version range matches root version #10386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2024
Merged

test(typescript-estree): add test to ensure TS version range matches root version #10386

merged 1 commit into from
Nov 25, 2024

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Nov 25, 2024 •
edited
Loading

PR Checklist

Overview

As mentioned in #10385 - adds a test to ensure we don't fall out of sync again

@bradzacher bradzacher added the tests anything to do with testing label Nov 25, 2024
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@bradzacher bradzacher mentioned this pull request Nov 25, 2024
Merged
3 tasks
@netlify Netlify
Copy link

netlify bot commented Nov 25, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 424a851
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6743e1060ab6fe0008ac7d33
😎 Deploy Preview https://deploy-preview-10386--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 25, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 424a851. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Nov 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.75%. Comparing base (30074a8) to head (424a851).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10386   +/-   ##
=======================================
  Coverage   86.75%   86.75%           
=======================================
  Files         443      443           
  Lines       15289    15289           
  Branches     4446     4446           
=======================================
  Hits        13264    13264           
  Misses       1672     1672           
  Partials      353      353
Flag Coverage Δ
unittest 86.75% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ipt-estree/src/parseSettings/warnAboutTSVersion.ts 94.11% <100.00%> (ø)
---- 🚨 Try these New Features:

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swell!

@bradzacher bradzacher merged commit 2aecd30 into main Nov 25, 2024
68 checks passed
@bradzacher bradzacher deleted the bjz/ensure-ts-version-range-sync branch November 25, 2024 03:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
tests anything to do with testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradzacher @JoshuaKGoldberg