Skip to content

docs: return-await doc page should say the rule is in the strict-type-checked ruleset, not recommended #10428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2024
Merged

docs: return-await doc page should say the rule is in the strict-type-checked ruleset, not recommended #10428

merged 1 commit into from
Nov 30, 2024

Conversation

y-hsgw
Copy link
Contributor

@y-hsgw y-hsgw commented Nov 30, 2024 •
edited
Loading

PR Checklist

Overview

Fix the condition for determining recommended.
🚀

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @y-hsgw!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@y-hsgw y-hsgw changed the title Docs: return-await doc page should say the rule is in the strict-type-checked ruleset, not recommended docs: return-await doc page should say the rule is in the strict-type-checked ruleset, not recommended Nov 30, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 30, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 9bbec21
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/674b0249e2d9ba000814fd22
😎 Deploy Preview https://deploy-preview-10428--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 92 (🔴 down 7 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 30, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9bbec21. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

kirkwaiblinger
kirkwaiblinger approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@kirkwaiblinger kirkwaiblinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thanks for sending this in!! ❤️

@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 30, 2024
Josh-Cena
Josh-Cena approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh

@Josh-Cena Josh-Cena merged commit 05617d2 into typescript-eslint:main Nov 30, 2024
74 of 77 checks passed
@y-hsgw y-hsgw deleted the docs/fix-return-await branch December 1, 2024 00:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kirkwaiblinger kirkwaiblinger kirkwaiblinger approved these changes

@Josh-Cena Josh-Cena Josh-Cena approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: return-await doc page should say the rule is in the strict-type-checked ruleset, not recommended
3 participants
@y-hsgw @kirkwaiblinger @Josh-Cena