typescript-eslint · bradzacher · Oct 14, 2019 · Oct 4, 2019 · Oct 8, 2019 · Oct 8, 2019
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -12,6 +12,7 @@
           "program": "${workspaceFolder}/node_modules/jest/bin/jest.js",
           "args": [
               "--runInBand",
+              "--no-coverage",
               // needs the '' around it so that the () are properly handled
               "'tests/(.+/)?${fileBasenameNoExtension}'"
           ],
@@ -27,6 +28,8 @@
         "program": "${workspaceFolder}/node_modules/jest/bin/jest.js",
         "args": [
             "--runInBand",
+            "--no-cache",
+            "--no-coverage",
             "${relativeFile}"
         ],
         "sourceMaps": true,

diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -22,6 +22,6 @@
   "javascript.preferences.importModuleSpecifier": "auto",
   "typescript.preferences.importModuleSpecifier": "auto",
   "javascript.preferences.quoteStyle": "single",
-"typescript.preferences.quoteStyle": "single",
-"editor.defaultFormatter": "esbenp.prettier-vscode"
+  "typescript.preferences.quoteStyle": "single",
+  "editor.defaultFormatter": "esbenp.prettier-vscode"
 }
diff --git a/README.md b/README.md
@@ -235,9 +235,9 @@ The latest version under the `canary` tag **(latest commit to master)** is:
 
 ## Supported TypeScript Version
 
-We will always endeavor to support the latest stable version of TypeScript. Sometimes, but not always, changes in TypeScript will not require breaking changes in this project, and so we are able to support more than one version of TypeScript.
+We will always endeavor to support the latest stable version of TypeScript. Sometimes, but not always, changes in TypeScript will not require breaking changes in this project, and so we are able to support more than one version of TypeScript. In some cases, we may even be able to support additional pre-releases (i.e. betas and release candidates) of TypeScript, but only if doing so does not require us to compromise on support for the latest stable version.
 
-**The version range of TypeScript currently supported by this parser is `>=3.2.1 <3.7.0`.**
+**The version range of TypeScript currently supported by this parser is `>=3.2.1 <3.8.0`.**
 
 This is reflected in the `devDependency` requirement within the package.json file, and it is what the tests will be run against. We have an open `peerDependency` requirement in order to allow for experimentation on newer/beta versions of TypeScript.
 

diff --git a/package.json b/package.json
@@ -73,10 +73,13 @@
     "ts-jest": "^24.0.0",
     "ts-node": "^8.3.0",
     "tslint": "^5.19.0",
-    "typescript": ">=3.2.1 <3.7.0"
+    "typescript": ">=3.2.1 <3.8.0 >3.7.0-dev.0"
   },
   "collective": {
     "type": "opencollective",
     "url": "https://opencollective.com/typescript-eslint"
+  },
+  "resolutions": {
+    "typescript": "^3.7.0-beta"
   }
 }
diff --git a/packages/eslint-plugin-tslint/tsconfig.json b/packages/eslint-plugin-tslint/tsconfig.json
@@ -1,8 +1,8 @@
 {
   "extends": "./tsconfig.build.json",
   "compilerOptions": {
-    "rootDir": ".",
-    "noEmit": true
+    "composite": false,
+    "rootDir": "."
   },
   "include": ["src", "tests"],
   "exclude": ["tests/test-project", "tests/test-tslint-rules-directory"]

diff --git a/packages/eslint-plugin/src/rules/adjacent-overload-signatures.ts b/packages/eslint-plugin/src/rules/adjacent-overload-signatures.ts
@@ -90,8 +90,6 @@ export default util.createRule({
         case AST_NODE_TYPES.TSTypeLiteral:
           return node.members;
       }
-
-      return [];
     }
 
     /**

diff --git a/packages/eslint-plugin/src/rules/indent.ts b/packages/eslint-plugin/src/rules/indent.ts
@@ -292,7 +292,7 @@ export default util.createRule<Options, MessageIds>({
                 range: moduleReference.range,
                 loc: moduleReference.loc,
               },
-            },
+            } as TSESTree.VariableDeclarator,
           ],
 
           // location data
@@ -313,6 +313,8 @@ export default util.createRule<Options, MessageIds>({
           parent: node.parent,
           range: node.range,
           loc: node.loc,
+          optional: false,
+          computed: true,
         });
       },
 
@@ -420,6 +422,8 @@ export default util.createRule<Options, MessageIds>({
           parent: node.parent,
           range: node.range,
           loc: node.loc,
+          optional: false,
+          computed: false,
         });
       },
 

diff --git a/packages/eslint-plugin/src/rules/prefer-readonly.ts b/packages/eslint-plugin/src/rules/prefer-readonly.ts
@@ -162,7 +162,9 @@ export default util.createRule<Options, MessageIds>({
     function getEsNodesFromViolatingNode(
       violatingNode: ParameterOrPropertyDeclaration,
     ): { esNode: TSESTree.Node; nameNode: TSESTree.Node } {
-      if (ts.isParameterPropertyDeclaration(violatingNode)) {
+      if (
+        ts.isParameterPropertyDeclaration(violatingNode, violatingNode.parent)
+      ) {
         return {
           esNode: parserServices.tsNodeToESTreeNodeMap.get(violatingNode.name),
           nameNode: parserServices.tsNodeToESTreeNodeMap.get(

diff --git a/packages/eslint-plugin/tsconfig.json b/packages/eslint-plugin/tsconfig.json
@@ -1,8 +1,8 @@
 {
   "extends": "./tsconfig.build.json",
   "compilerOptions": {
-    "rootDir": ".",
-    "noEmit": true
+    "composite": false,
+    "rootDir": "."
   },
   "include": ["src", "typings", "tests", "tools"]
 }
diff --git a/packages/experimental-utils/tsconfig.json b/packages/experimental-utils/tsconfig.json
@@ -1,8 +1,8 @@
 {
   "extends": "./tsconfig.build.json",
   "compilerOptions": {
-    "rootDir": ".",
-    "noEmit": true
+    "composite": false,
+    "rootDir": "."
   },
   "include": ["src", "typings", "tests", "tools"]
 }
diff --git a/packages/parser/src/visitor-keys.ts b/packages/parser/src/visitor-keys.ts
@@ -43,6 +43,8 @@ export const visitorKeys = eslintVisitorKeys.unionWith({
   BigIntLiteral: [],
   ClassProperty: ['decorators', 'key', 'typeAnnotation', 'value'],
   Decorator: ['expression'],
+  OptionalCallExpression: eslintVisitorKeys.KEYS.CallExpression,
+  OptionalMemberExpression: eslintVisitorKeys.KEYS.MemberExpression,
   TSAbstractClassProperty: ['decorators', 'key', 'typeAnnotation', 'value'],
   TSAbstractKeyword: [],
   TSAbstractMethodDefinition: ['key', 'value'],

diff --git a/packages/parser/tests/lib/__snapshots__/comments.ts.snap b/packages/parser/tests/lib/__snapshots__/comments.ts.snap
@@ -36,6 +36,7 @@ Object {
                 "line": 2,
               },
             },
+            "optional": false,
             "range": Array [
               6,
               9,
@@ -11708,6 +11709,7 @@ Object {
                   "line": 2,
                 },
               },
+              "optional": false,
               "range": Array [
                 24,
                 37,
@@ -12589,6 +12591,7 @@ Object {
                   "line": 2,
                 },
               },
+              "optional": false,
               "range": Array [
                 24,
                 37,
@@ -14189,6 +14192,7 @@ Object {
                   "line": 3,
                 },
               },
+              "optional": false,
               "range": Array [
                 36,
                 41,
@@ -15965,6 +15969,7 @@ Object {
                     "line": 6,
                   },
                 },
+                "optional": false,
                 "range": Array [
                   82,
                   88,
@@ -16485,6 +16490,7 @@ Object {
                           "line": 7,
                         },
                       },
+                      "optional": false,
                       "range": Array [
                         126,
                         132,
@@ -18181,6 +18187,7 @@ Object {
             ],
             "type": "Identifier",
           },
+          "optional": false,
           "property": Object {
             "loc": Object {
               "end": Object {
@@ -18277,6 +18284,7 @@ Object {
                                         ],
                                         "type": "Identifier",
                                       },
+                                      "optional": false,
                                       "property": Object {
                                         "loc": Object {
                                           "end": Object {
@@ -18301,6 +18309,7 @@ Object {
                                       ],
                                       "type": "MemberExpression",
                                     },
+                                    "optional": false,
                                     "property": Object {
                                       "left": Object {
                                         "computed": false,
@@ -18344,6 +18353,7 @@ Object {
                                             ],
                                             "type": "Identifier",
                                           },
+                                          "optional": false,
                                           "property": Object {
                                             "loc": Object {
                                               "end": Object {
@@ -18368,6 +18378,7 @@ Object {
                                           ],
                                           "type": "MemberExpression",
                                         },
+                                        "optional": false,
                                         "property": Object {
                                           "loc": Object {
                                             "end": Object {
@@ -18463,6 +18474,7 @@ Object {
                                     "line": 6,
                                   },
                                 },
+                                "optional": false,
                                 "range": Array [
                                   161,
                                   218,
@@ -18552,6 +18564,7 @@ Object {
                           ],
                           "type": "Identifier",
                         },
+                        "optional": false,
                         "property": Object {
                           "loc": Object {
                             "end": Object {
-Original file line number
+Diff line change
@@ Expand Up / @@ -90,8 +90,6 @@ export default util.createRule({ @@
             case AST_NODE_TYPES.TSTypeLiteral:
               return node.members;
           }
-          return [];
         }
         /**
@@ Expand Down @@