fix(eslint-plugin): Add missing rule functions #1047
Conversation
|
Thanks for the PR, @Validark! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
| @@ -348,6 +361,7 @@ interface RuleListener { | |||
| TSProtectedKeyword?: RuleFunction<TSESTree.TSProtectedKeyword>; | |||
| TSPublicKeyword?: RuleFunction<TSESTree.TSPublicKeyword>; | |||
| TSQualifiedName?: RuleFunction<TSESTree.TSQualifiedName>; | |||
| // TSQuestionToken?: RuleFunction<TSESTree.TSQuestionToken>; | |||
There was a problem hiding this comment.
this should be handled by Token, shouldn't it?
There was a problem hiding this comment.
No idea, just saw it in AST_NODE_TYPES.
There was a problem hiding this comment.
ahh yes, it shouldn't be in there.
Feel free to remove it from AST_NODE_TYPES.
I pulled all keys missing from
RuleListenerwhich are present inAST_NODE_TYPES, and found the added RuleFunctions were missing.JSXNamespacedNameandTSQuestionTokendidn't have definitions inTSESTreeand don't appear to work at the moment, so I commented them out as placeholders.Also made
ClassPropertyBase.valuenullable, since it can be null when the class property is not assigned a value. e.g.