Skip to content

fix(eslint-plugin): [array-type] autofix TsConditionalType to be wrapped with parentheses #10521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ronami
Copy link
Member

@ronami ronami commented Dec 19, 2024

PR Checklist

Overview

This PR tackles #10519 and adds missing parentheses when auto-fixing a TsConditionalType.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ronami!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 44d65cd
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67643fd48df0d700081b4201
😎 Deploy Preview https://deploy-preview-10521--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 21 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Dec 19, 2024

View your CI Pipeline Execution ↗ for commit 44d65cd.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 4s View ↗
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-19 16:01:54 UTC

@ronami
Copy link
Member Author

ronami commented Dec 19, 2024

Closing in favor of #10522.

@ronami ronami closed this Dec 19, 2024
@ronami ronami deleted the array-type-conditional-type-needs-parens branch December 19, 2024 15:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: array-type automatic fix changes type logic when used with conditional types
1 participant