fix(eslint-plugin): [member-ordering] ignore method overloading #10536

yeonjuan · 2024-12-21T17:13:26Z

PR Checklist

Addresses an existing open issue: fixes [member-ordering] decorated method overloads have unexpected behavior #2409
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Change this rule to ignore overloading method definitions that do not have an implementation. #2409 (comment)

class Foo {
    myMethod(a: string); // skip
    myMethod(a: number); // skip
    myMethod(a: number, b: string); // skip
    myMethod(a: string | number, b?: string) { // check
        alert(a.toString());
    }
}

typescript-eslint · 2024-12-21T17:13:29Z

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2024-12-21T17:13:46Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`bc569e4`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6767c7f1b2610d000868a06d
😎 Deploy Preview	https://deploy-preview-10536--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 21 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2024-12-21T17:14:15Z

View your CI Pipeline Execution ↗ for commit bc569e4.

Command	Status	Duration	Result
`nx run-many --target=build --exclude website --...`	✅ Succeeded	2s	View ↗
`nx run-many --target=clean`	✅ Succeeded	11s	View ↗

☁️ Nx Cloud last updated this comment at 2024-12-22 15:35:50 UTC

codecov · 2024-12-21T17:27:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.84%. Comparing base (b2ce158) to head (bc569e4).
Report is 26 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10536      +/-   ##
==========================================
+ Coverage   86.78%   86.84%   +0.05%     
==========================================
  Files         445      445              
  Lines       15366    15427      +61     
  Branches     4475     4499      +24     
==========================================
+ Hits        13336    13397      +61     
  Misses       1675     1675              
  Partials      355      355

Flag	Coverage Δ
unittest	`86.84% <100.00%> (+0.05%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ackages/eslint-plugin/src/rules/member-ordering.ts	`96.66% <100.00%> (+0.04%)`	⬆️

... and 7 files with indirect coverage changes

yeonjuan · 2024-12-22T15:31:23Z

packages/eslint-plugin/tests/rules/member-ordering.test.ts

@@ -4471,7 +4517,7 @@ class Foo {
 abstract class Foo {
  abstract B: string;
  abstract A(): void;
-  public C(): {};
+  public C() {}


This is probably a typo. The following TS error occurs because {} is a return type
Function implementation is missing or not immediately following the declaration.

JoshuaKGoldberg

Nice! 👏

Now we only have one issue about member-ordering left... very pleased. 😄

@kirkwaiblinger

##### [v8.19.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8190-2024-12-30) ##### 🚀 Features - **eslint-plugin:** \[strict-boolean-expressions] check array predicate functions' return statements ([#10106](typescript-eslint/typescript-eslint#10106)) ##### 🩹 Fixes - **eslint-plugin:** \[member-ordering] ignore method overloading ([#10536](typescript-eslint/typescript-eslint#10536)) - **eslint-plugin:** \[consistent-indexed-object-style] don't report on indirect circular references ([#10537](typescript-eslint/typescript-eslint#10537)) - **eslint-plugin:** \[array-type] autofix with conditional types needs parentheses ([#10522](typescript-eslint/typescript-eslint#10522)) - **eslint-plugin:** add getConstraintInfo to handle generic constraints better ([#10496](typescript-eslint/typescript-eslint#10496)) ##### ❤️ Thank You - Karl Werner - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - Ronen Amiel - YeonJuan [@yeonjuan](https://github.com/yeonjuan) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

…script-eslint#10536) * fix(eslint-plugin): [member-ordering] ignore method overloading * refactor

@kirkwaiblinger

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.18.2 | 8.19.0 | | npm | @typescript-eslint/parser | 8.18.2 | 8.19.0 | ## [v8.19.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8190-2024-12-30) ##### 🚀 Features - **eslint-plugin:** \[strict-boolean-expressions] check array predicate functions' return statements ([#10106](typescript-eslint/typescript-eslint#10106)) ##### 🩹 Fixes - **eslint-plugin:** \[member-ordering] ignore method overloading ([#10536](typescript-eslint/typescript-eslint#10536)) - **eslint-plugin:** \[consistent-indexed-object-style] don't report on indirect circular references ([#10537](typescript-eslint/typescript-eslint#10537)) - **eslint-plugin:** \[array-type] autofix with conditional types needs parentheses ([#10522](typescript-eslint/typescript-eslint#10522)) - **eslint-plugin:** add getConstraintInfo to handle generic constraints better ([#10496](typescript-eslint/typescript-eslint#10496)) ##### ❤️ Thank You - Karl Werner - Kirk Waiblinger [@kirkwaiblinger](https://github.com/kirkwaiblinger) - Ronen Amiel - YeonJuan [@yeonjuan](https://github.com/yeonjuan) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

fix(eslint-plugin): [member-ordering] ignore method overloading

f707f3a

refactor

bc569e4

yeonjuan commented Dec 22, 2024

View reviewed changes

yeonjuan marked this pull request as ready for review December 22, 2024 15:35

JoshuaKGoldberg approved these changes Dec 30, 2024

View reviewed changes

JoshuaKGoldberg merged commit 9746832 into typescript-eslint:main Dec 30, 2024
65 checks passed

OlivierZal pushed a commit to OlivierZal/typescript-eslint that referenced this pull request Dec 30, 2024

fix(eslint-plugin): [member-ordering] ignore method overloading (type…

69b4562

…script-eslint#10536) * fix(eslint-plugin): [member-ordering] ignore method overloading * refactor

github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(eslint-plugin): [member-ordering] ignore method overloading #10536

fix(eslint-plugin): [member-ordering] ignore method overloading #10536

yeonjuan commented Dec 21, 2024 •

edited

Loading

typescript-eslint bot commented Dec 21, 2024

netlify bot commented Dec 21, 2024 •

edited

Loading

nx-cloud bot commented Dec 21, 2024 •

edited

Loading

codecov bot commented Dec 21, 2024 •

edited

Loading

yeonjuan Dec 22, 2024 •

edited

Loading

JoshuaKGoldberg left a comment

fix(eslint-plugin): [member-ordering] ignore method overloading #10536

fix(eslint-plugin): [member-ordering] ignore method overloading #10536

Conversation

yeonjuan commented Dec 21, 2024 • edited Loading

PR Checklist

Overview

typescript-eslint bot commented Dec 21, 2024

netlify bot commented Dec 21, 2024 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

nx-cloud bot commented Dec 21, 2024 • edited Loading

codecov bot commented Dec 21, 2024 • edited Loading

Codecov Report

yeonjuan Dec 22, 2024 • edited Loading

Choose a reason for hiding this comment

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

yeonjuan commented Dec 21, 2024 •

edited

Loading

netlify bot commented Dec 21, 2024 •

edited

Loading

nx-cloud bot commented Dec 21, 2024 •

edited

Loading

codecov bot commented Dec 21, 2024 •

edited

Loading

yeonjuan Dec 22, 2024 •

edited

Loading