Thanks for the PR, @james-pre!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	42eb0b2
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6769e15bc4ae310008db55ee
😎 Deploy Preview	https://deploy-preview-10544--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 76 (🟢 up 3 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

View your CI Pipeline Execution ↗ for commit 42eb0b2.

☁️ Nx Cloud last updated this comment at 2024-12-23 22:34:34 UTC

The error message for the test doesn't make sense to me, as _tinyglobby doesn't even exist in the scope:

 FAIL  tests/lib/parse.test.ts
  ● Test suite failed to run
    ReferenceError: Cannot access '_tinyglobby' before initialization
      45 |   return {
      46 |     ...tg,
    > 47 |     globSync: jest.fn(tinyglobby.globSync),
         |                       ^
      48 |   };
      49 | });
      50 |
      at tinyglobby (tests/lib/parse.test.ts:47:23)
      at Object.<anonymous> (tests/lib/parse.test.ts:34:61)

Some insight would be appreciated.

@james-pre I appreciate the enthusiasm for getting this in 🙂. But was there a reason you deleted the PR template? We have it because we like it and it makes sure folks know the steps they're meant to take before sending a PR.

I'm converting this to draft because the issue hasn't been accepted and there are some test failures. Feel free to keep working on it in the meantime, it's great to see it almost fully working! 🚀

Sorry on the PR check list, I re-added it. Please let me know if there is anything I can do to move this forward.

Thanks! There are two blockers I think:

• More input from the team on Enhancement: replace fast-glob with tinyglobby #10533, just in case there's a better alternative strategy
• CI -in particular unit tests- passing on this PR

For issue input, we're just waiting. Given that this is holiday season it might be a business week or two till we get that.

For CI, that's something you could do.

Per #10533 (comment) we're going to hold off for a few months on the switch. tinyglobby is not stable enough yet for us to use it.

This is a big part of why we ask that folks go by the contributing guidelines. It feels bad to close a PR with good work in it like this one. But you never know when a seemingly straightforward+good issue is actually not ready to be accepted yet.

Thanks! ❤️

@JoshuaKGoldberg All of the tests passed (actions workflow), so I don't believe the instability issues mentioned in the comment are applicable. What do you think?

(answering in #10533)

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.84%. Comparing base (4747299) to head (42eb0b2).
Report is 3 commits behind head on main.

@@           Coverage Diff           @@
##             main   #10544   +/-   ##
=======================================
  Coverage   86.83%   86.84%           
=======================================
  Files         445      445           
  Lines       15424    15428    +4     
  Branches     4497     4497           
=======================================
+ Hits        13394    13398    +4     
  Misses       1675     1675           
  Partials      355      355