chore: export all Options and MessageIds types from rule files #10556
Conversation
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
View your CI Pipeline Execution ↗ for commit c5f6e40.
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
I think these rules have been missed:
await-thenableno-array-deleteno-confusing-non-null-assertionno-floating-promisesno-misused-promisesno-unnecessary-template-expressionrestrict-template-expressions
Also, these two rules, which don't export their Options, or export a slightly different Options type than the one they use:
PR Checklist
Overview
Doesn't export all types that will be flagged by #10554. I think it'll still be useful to make sure the PR's added rule correctly flags internal violations.
💖