Skip to content

chore(eslint-plugin): no-confusing-void-expression getConstraintInfo #10586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(eslint-plugin): no-confusing-void-expression getConstraintInfo #10586

wants to merge 1 commit into from

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Jan 1, 2025

Moves to using getConstraintInfo internally in the no-confusing-void-expression rule.

Also fixes a bug this uncovered, where AwaitExpression nodes were actually untested and not supported in the type constraint checks.

This is because we passed node (the AwaitExpression itself), rather than the thing being awaited (node.argument). By passing the argument, we check its type instead.

PR Checklist

@43081j
chore(eslint-plugin): no-confusing-void-expression getConstraintInfo
59a8b4a 
Moves to using `getConstraintInfo` internally in the
`no-confusing-void-expression` rule.

Also fixes a bug this uncovered, where `AwaitExpression` nodes were
actually untested and not supported in the type constraint checks.

This is because we passed `node` (the `AwaitExpression` itself), rather
than the thing being awaited (`node.argument`). By passing the
`argument`, we check its type instead.
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @43081j!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jan 1, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 59a8b4a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67753ddc10a8ea0008baf09e
😎 Deploy Preview https://deploy-preview-10586--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 93 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 1, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 59a8b4a.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 4s View ↗
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-04 17:23:21 UTC

@codecov Codecov
Copy link

codecov bot commented Jan 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.90%. Comparing base (4dbf48b) to head (59a8b4a).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10586   +/-   ##
=======================================
  Coverage   86.90%   86.90%           
=======================================
  Files         446      446           
  Lines       15502    15508    +6     
  Branches     4516     4519    +3     
=======================================
+ Hits        13472    13478    +6     
  Misses       1675     1675           
  Partials      355      355
Flag Coverage Δ
unittest 86.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...t-plugin/src/rules/no-confusing-void-expression.ts 100.00% <100.00%> (ø)

@kirkwaiblinger
Copy link
Member

#10603 (comment)

@kirkwaiblinger kirkwaiblinger added the blocked by another issue Issues which are not ready because another issue needs to be resolved first label Jan 4, 2025
@kirkwaiblinger kirkwaiblinger marked this pull request as draft January 4, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
blocked by another issue Issues which are not ready because another issue needs to be resolved first
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@43081j @kirkwaiblinger