Skip to content

fix(eslint-plugin): [no-unnecessary-type-assertion] work with enum #10591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(eslint-plugin): [no-unnecessary-type-assertion] work with enum #10591

wants to merge 1 commit into from

Conversation

mdm317
Copy link
Contributor

@mdm317 mdm317 commented Jan 2, 2025

PR Checklist

Overview

Fix to work with enums

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @mdm317!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@mdm317 mdm317 marked this pull request as draft January 2, 2025 14:07
@netlify Netlify
Copy link

netlify bot commented Jan 2, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 62992b2
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67769d8bf1944000088e8764
😎 Deploy Preview https://deploy-preview-10591--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 2, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 62992b2.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 2s View ↗
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-09 16:56:25 UTC

@codecov Codecov
Copy link

codecov bot commented Jan 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.90%. Comparing base (4dbf48b) to head (62992b2).
Report is 50 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10591   +/-   ##
=======================================
  Coverage   86.90%   86.90%           
=======================================
  Files         446      446           
  Lines       15502    15503    +1     
  Branches     4516     4517    +1     
=======================================
+ Hits        13472    13473    +1     
  Misses       1675     1675           
  Partials      355      355
Flag Coverage Δ
unittest 86.90% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...-plugin/src/rules/no-unnecessary-type-assertion.ts 97.97% <100.00%> (+0.02%) ⬆️

@mdm317 mdm317 marked this pull request as ready for review January 2, 2025 16:27
JoshuaKGoldberg
JoshuaKGoldberg requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this started!

packages/eslint-plugin/tests/rules/no-unnecessary-type-assertion.test.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Testing] Could you also include some valid cases around enums please?

Since #10523 had to be reverted, we're kind of on high alert for this rule now 😄. I think there will need to be some thorough tests around enums.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reply!
I think it has a similar issue to that one. I'll move it to draft, fix it, and then request again.

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jan 7, 2025
@mdm317 mdm317 marked this pull request as draft January 7, 2025 17:39
@JoshuaKGoldberg JoshuaKGoldberg removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jan 9, 2025
@mdm317
Copy link
Contributor Author

mdm317 commented Jan 22, 2025 •
edited
Loading

I think this PR will also resolve this issue, so I will close this PR.

@mdm317 mdm317 closed this Jan 22, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-unnecessary-type-assertion] Does not work with enums
2 participants
@mdm317 @JoshuaKGoldberg