Skip to content

chore(eslint-plugin): [no-for-in-array] use getConstraintInfo #10601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

43081j
Copy link
Contributor

@43081j 43081j commented Jan 3, 2025

Uses getConstraintInfo for determining if the right hand side of the for..in is constrained or not.

PR Checklist

Uses `getConstraintInfo` for determining if the right hand side of the
`for..in` is constrained or not.
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @43081j!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 7ca6365
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6777f63ad6d4bc00089c57bb
😎 Deploy Preview https://deploy-preview-10601--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Jan 3, 2025

View your CI Pipeline Execution ↗ for commit 7ca6365.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 2s View ↗
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-04 17:22:52 UTC

@kirkwaiblinger kirkwaiblinger marked this pull request as draft January 4, 2025 17:21
@kirkwaiblinger kirkwaiblinger added the blocked by another issue Issues which are not ready because another issue needs to be resolved first label Jan 4, 2025
@kirkwaiblinger
Copy link
Member

#10603 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked by another issue Issues which are not ready because another issue needs to be resolved first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants