Skip to content

fix: revert "fix(eslint-plugin): [no-unnecessary-type-assertion] handle literal types" #10620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

Reverts #10523

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f1f53ee
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/677bfba80ffd7300087b7196
😎 Deploy Preview https://deploy-preview-10620--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 92 (🟢 up 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Jan 6, 2025

View your CI Pipeline Execution ↗ for commit f1f53ee.

Command Status Duration Result
nx run-many --target=build --exclude website --... ✅ Succeeded 1s View ↗
nx run-many --target=clean ✅ Succeeded 14s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-06 16:05:18 UTC

@JoshuaKGoldberg JoshuaKGoldberg merged commit 6e05e56 into main Jan 6, 2025
59 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the revert-10523-fix/10275-no-unnecessary-type-assertion branch January 6, 2025 16:00
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.90%. Comparing base (5d7d7b5) to head (f1f53ee).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10620      +/-   ##
==========================================
- Coverage   86.91%   86.90%   -0.01%     
==========================================
  Files         446      446              
  Lines       15509    15508       -1     
  Branches     4519     4518       -1     
==========================================
- Hits        13479    13478       -1     
  Misses       1675     1675              
  Partials      355      355              
Flag Coverage Δ
unittest 86.90% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...-plugin/src/rules/no-unnecessary-type-assertion.ts 97.95% <100.00%> (-0.03%) ⬇️

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant