Skip to content

fix(eslint-plugin): [no-unnecessary-type-arguments] handle type args on jsx #10630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2025
Merged

fix(eslint-plugin): [no-unnecessary-type-arguments] handle type args on jsx #10630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bb20ed
fix(eslint-plugin): [no-unnecessary-type-arguments] handle type args …
yeonjuan Jan 7, 2025
672f533
apply review
yeonjuan Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/eslint-plugin/src/rules/no-unnecessary-type-arguments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,9 @@ function getTypeParametersFromNode(
if (
ts.isCallExpression(tsNode) ||
ts.isNewExpression(tsNode) ||
ts.isTaggedTemplateExpression(tsNode)
ts.isTaggedTemplateExpression(tsNode) ||
ts.isJsxOpeningElement(tsNode) ||
ts.isJsxSelfClosingElement(tsNode)
) {
return getTypeParametersFromCall(node, tsNode, checker);
}
Expand Down Expand Up @@ -189,7 +191,12 @@ function getTypeParametersFromType(

function getTypeParametersFromCall(
node: TSESTree.TSTypeParameterInstantiation,
tsNode: ts.CallExpression | ts.NewExpression | ts.TaggedTemplateExpression,
tsNode:
| ts.CallExpression
| ts.JsxOpeningElement
| ts.JsxSelfClosingElement
| ts.NewExpression
| ts.TaggedTemplateExpression,
checker: ts.TypeChecker,
): readonly ts.TypeParameterDeclaration[] | undefined {
const sig = checker.getResolvedSignature(tsNode);
Expand Down
84 changes: 84 additions & 0 deletions packages/eslint-plugin/tests/rules/no-unnecessary-type-arguments.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,36 @@ namespace Foo {
}
class Bar extends Foo<string> {}
`,
{
code: `
function Button<T>() {
return <div></div>;
}
const button = <Button<string>></Button>;
`,
languageOptions: {
parserOptions: {
ecmaFeatures: {
jsx: true,
},
},
},
},
{
code: `
function Button<T>() {
return <div></div>;
}
const button = <Button<string> />;
`,
languageOptions: {
parserOptions: {
ecmaFeatures: {
jsx: true,
},
},
},
},
],
invalid: [
{
Expand Down Expand Up @@ -560,5 +590,59 @@ namespace Foo {
class Bar extends Foo {}
`,
},
{
code: `
function Button<T = string>() {
return <div></div>;
}
const button = <Button<string>></Button>;
`,
errors: [
{
line: 5,
messageId: 'unnecessaryTypeParameter',
},
],
languageOptions: {
parserOptions: {
ecmaFeatures: {
jsx: true,
},
},
},
output: `
function Button<T = string>() {
return <div></div>;
}
const button = <Button></Button>;
`,
},
{
code: `
function Button<T = string>() {
return <div></div>;
}
const button = <Button<string> />;
`,
errors: [
{
line: 5,
messageId: 'unnecessaryTypeParameter',
},
],
languageOptions: {
parserOptions: {
ecmaFeatures: {
jsx: true,
},
},
},
output: `
function Button<T = string>() {
return <div></div>;
}
const button = <Button />;
`,
},
],
});
Loading