Thanks for the PR, @dmichon-msft!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	1210cad
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/67c4f4929f3bf7000801d25a
😎 Deploy Preview	https://deploy-preview-10647--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 95 (🔴 down 3 from production) Accessibility: 100 (no change from production) Best Practices: 100 (🟢 up 8 from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

View your CI Pipeline Execution ↗ for commit 1210cad.

☁️ Nx Cloud last updated this comment at 2025-03-03 00:50:59 UTC

Since you gave me license to restructure the objects from the individual lib files, I went ahead and separated out the concept of "references to other libs" from individual variable definitions, so that in the (unfortunately rather common) case that developers have specified their lib array in such a way that a given lib is included multiple times, we only iterate the variables from it once (per source file, still).

I'm happy to go with a bigger refactor of how all of this works.
We should be able to mitigate the cost of loading libs and the cost of defining variables using this approach which is nice.

Just need to get the tests passing and we can move forward with this!

I can rebase/merge this to reconcile the changes to exports that happened a bit back, I just hadn't since the guidance was to leave that to maintainers.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.44%. Comparing base (9674629) to head (1210cad).
Report is 1 commits behind head on main.

@@           Coverage Diff           @@
##             main   #10647   +/-   ##
=======================================
  Coverage   87.44%   87.44%           
=======================================
  Files         469      469           
  Lines       16047    16053    +6     
  Branches     4649     4650    +1     
=======================================
+ Hits        14032    14038    +6     
  Misses       1658     1658           
  Partials      357      357           

thanks heaps for this!

Before this change, running https://github.com/typescript-eslint/performance:

┌───────┬───────────────────────┬───────────────────────┐
│ files │ project (even layout) │ service (even layout) │
├───────┼───────────────────────┼───────────────────────┤
│ 1024  │ '2.760 s ±  0.006 s'  │ '3.125 s ±  0.011 s'  │
└───────┴───────────────────────┴───────────────────────┘

After:

┌───────┬───────────────────────┬───────────────────────┐
│ files │ project (even layout) │ service (even layout) │
├───────┼───────────────────────┼───────────────────────┤
│ 1024  │ '2.478 s ±  0.022 s'  │ '2.829 s ±  0.020 s'  │
└───────┴───────────────────────┴───────────────────────┘

Nice 🔥