Skip to content

fix(eslint-plugin): check JSX spread elements for misused spread usage #10653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 18, 2025
Merged

fix(eslint-plugin): check JSX spread elements for misused spread usage #10653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad1467a
report on misused jsx spread attribute
ronami Jan 14, 2025
5cb9cb2
Merge branch 'main' into no-misused-spread-jsx
ronami Jan 15, 2025
d8ecc9c
Merge branch 'main' into no-misused-spread-jsx
ronami Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/eslint-plugin/src/rules/no-misused-spread.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,9 @@ export default createRule<Options, MessageIds>({
}
}

function checkObjectSpread(node: TSESTree.SpreadElement): void {
function checkObjectSpread(
node: TSESTree.JSXSpreadAttribute | TSESTree.SpreadElement,
): void {
const type = getConstrainedTypeAtLocation(services, node.argument);

if (typeMatchesSomeSpecifier(type, options.allow, services.program)) {
Expand Down Expand Up @@ -175,6 +177,7 @@ export default createRule<Options, MessageIds>({
return {
'ArrayExpression > SpreadElement': checkArrayOrCallSpread,
'CallExpression > SpreadElement': checkArrayOrCallSpread,
JSXSpreadAttribute: checkObjectSpread,
'ObjectExpression > SpreadElement': checkObjectSpread,
};
},
Expand Down
175 changes: 175 additions & 0 deletions packages/eslint-plugin/tests/rules/no-misused-spread.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,32 @@ ruleTester.run('no-misused-spread', rule, {

const o = { ...promiseLike };
`,
{
code: `
const obj = { a: 1, b: 2 };
const o = <div {...x} />;
`,
languageOptions: {
parserOptions: {
ecmaFeatures: {
jsx: true,
},
},
},
},
{
code: `
declare const obj: { a: number; b: number } | any;
const o = <div {...x} />;
`,
languageOptions: {
parserOptions: {
ecmaFeatures: {
jsx: true,
},
},
},
},

{
code: `
Expand Down Expand Up @@ -1493,5 +1519,154 @@ ruleTester.run('no-misused-spread', rule, {
},
],
},

{
code: `
const o = <div {...[1, 2, 3]} />;
`,
errors: [
{
column: 24,
endColumn: 38,
line: 2,
messageId: 'noArraySpreadInObject',
},
],
languageOptions: {
parserOptions: {
ecmaFeatures: {
jsx: true,
},
},
},
},
{
code: `
class A {}

const o = <div {...A} />;
`,
errors: [
{
column: 24,
endColumn: 30,
line: 4,
messageId: 'noClassDeclarationSpreadInObject',
},
],
languageOptions: {
parserOptions: {
ecmaFeatures: {
jsx: true,
},
},
},
},
{
code: `
const o = <div {...new Date()} />;
`,
errors: [
{
column: 24,
endColumn: 39,
line: 2,
messageId: 'noClassInstanceSpreadInObject',
},
],
languageOptions: {
parserOptions: {
ecmaFeatures: {
jsx: true,
},
},
},
},
{
code: `
function f() {}

const o = <div {...f} />;
`,
errors: [
{
column: 24,
endColumn: 30,
line: 4,
messageId: 'noFunctionSpreadInObject',
},
],
languageOptions: {
parserOptions: {
ecmaFeatures: {
jsx: true,
},
},
},
},
{
code: `
const o = <div {...new Set([1, 2, 3])} />;
`,
errors: [
{
column: 24,
endColumn: 47,
line: 2,
messageId: 'noIterableSpreadInObject',
},
],
languageOptions: {
parserOptions: {
ecmaFeatures: {
jsx: true,
},
},
},
},
{
code: `
declare const map: Map<string, number>;

const o = <div {...map} />;
`,
errors: [
{
column: 24,
endColumn: 32,
line: 4,
messageId: 'noMapSpreadInObject',
},
],
languageOptions: {
parserOptions: {
ecmaFeatures: {
jsx: true,
},
},
},
},
{
code: `
const promise = new Promise(() => {});

const o = <div {...promise} />;
`,
errors: [
{
column: 24,
endColumn: 36,
line: 4,
messageId: 'noPromiseSpreadInObject',
},
],
languageOptions: {
parserOptions: {
ecmaFeatures: {
jsx: true,
},
},
},
},
],
});
Loading