Skip to content

chore(scope-manager): migrate from jest to vitest #10677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
Apr 14, 2025
Merged

chore(scope-manager): migrate from jest to vitest #10677

merged 47 commits into from
Apr 14, 2025

Conversation

aryaemami59
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @aryaemami59!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jan 18, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 45e2a9e
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/67fd0ff137c3e30008f030cb
😎 Deploy Preview https://deploy-preview-10677--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🟢 up 11 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 18, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 45e2a9e.

Command Status Duration Result
nx typecheck ast-spec ✅ Succeeded <1s View ↗
nx run-many --target=build --exclude website --... ✅ Succeeded 48s View ↗
nx run-many --target=clean ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-14 13:55:32 UTC

@aryaemami59 aryaemami59 force-pushed the chore/scope-manager-vitest-migration branch from 0759e1c to db79012 Compare January 18, 2025 11:31
@codecov Codecov
Copy link

codecov bot commented Jan 18, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.91%. Comparing base (ee9b585) to head (45e2a9e).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10677      +/-   ##
==========================================
+ Coverage   88.17%   88.91%   +0.74%     
==========================================
  Files         497      496       -1     
  Lines       17840    23713    +5873     
  Branches     4803     4896      +93     
==========================================
+ Hits        15730    21084    +5354     
- Misses       1775     2356     +581     
+ Partials      335      273      -62
Flag Coverage Δ
unittest 88.91% <ø> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 178 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

43081j
43081j reviewed Jan 18, 2025
View reviewed changes
@aryaemami59 aryaemami59 force-pushed the chore/scope-manager-vitest-migration branch 2 times, most recently from a27a082 to 9115d46 Compare January 21, 2025 17:17
@aryaemami59 aryaemami59 force-pushed the chore/scope-manager-vitest-migration branch 22 times, most recently from 5865fbd to 329dc1d Compare February 3, 2025 17:27
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jan 28, 2025
Closed
14 tasks
aryaemami59 and others added 16 commits April 11, 2025 10:08
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
aad0109 
…t-eslint into chore/scope-manager-vitest-migration
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
f33bf72 
…t-eslint into chore/scope-manager-vitest-migration
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
f382f9c 
…t-eslint into chore/scope-manager-vitest-migration
@aryaemami59
Merge branch 'main' of https://github.com/typescript-eslint/typescrip…
2128e85 
…t-eslint into chore/scope-manager-vitest-migration
@aryaemami59
Run ast-spec:typecheck during postinstall
fe0b2c3
@aryaemami59
Fix ast-spec:test
3e9c2e1
@aryaemami59
Fix ast-spec:build
3bc0e8f
@aryaemami59
Try disabling remote cache
0c6d484
@aryaemami59
Try disabling remote cache
1b2e0ac
@aryaemami59
Update typecheck output path in nx.json
b460a94
@aryaemami59
Fix vitest coverage output when run with nx
cfd2235
@aryaemami59
Fix scope-manager tests
7b2aa04
@JoshuaKGoldberg
Merge branch 'main'
edc1b9d
@JoshuaKGoldberg
remove downlevel-dts line
9a26ce3
@JoshuaKGoldberg
remove postbuild in scope-manager package.json
b1aad69
@JoshuaKGoldberg
Merge branch 'main'
45e2a9e
@JoshuaKGoldberg JoshuaKGoldberg merged commit e8ea7a4 into typescript-eslint:main Apr 14, 2025
52 of 53 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2025
@aryaemami59 aryaemami59 deleted the chore/scope-manager-vitest-migration branch April 23, 2025 00:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

@43081j 43081j 43081j left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aryaemami59 @JoshuaKGoldberg @43081j @kirkwaiblinger