fix(eslint-plugin): [no-extraneous-class] handle accessor keyword #10678

mdm317 · 2025-01-18T11:53:51Z

PR Checklist

Addresses an existing open issue: fixes Bug: [no-extraneous-class] false positive with accessor #10676
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

typescript-eslint · 2025-01-18T11:53:53Z

Thanks for the PR, @mdm317!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

nx-cloud · 2025-01-18T11:54:41Z

View your CI Pipeline Execution ↗ for commit 2b512a7.

Command	Status	Duration	Result
`nx run-many --target=build --exclude website --...`	✅ Succeeded	2s	View ↗
`nx run-many --target=clean`	✅ Succeeded	13s	View ↗

☁️ Nx Cloud last updated this comment at 2025-01-23 18:54:24 UTC

netlify · 2025-01-18T11:55:23Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`2b512a7`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/679216e9d5048e00081d5113
😎 Deploy Preview	https://deploy-preview-10678--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (no change from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 98 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

ronami

Looking good! Thanks for sending this in, just requesting a small adjustment around abstract accessor properties 💯

packages/eslint-plugin/src/rules/no-extraneous-class.ts

codecov · 2025-01-23T10:32:18Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.17%. Comparing base (31be053) to head (2b512a7).
Report is 28 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10678      +/-   ##
==========================================
+ Coverage   87.15%   87.17%   +0.01%     
==========================================
  Files         448      448              
  Lines       15576    15598      +22     
  Branches     4551     4555       +4     
==========================================
+ Hits        13575    13597      +22     
  Misses       1645     1645              
  Partials      356      356

Flag	Coverage Δ
unittest	`87.17% <ø> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ges/eslint-plugin/src/rules/no-extraneous-class.ts	`97.36% <ø> (ø)`

... and 6 files with indirect coverage changes

ronami

🚀 Nice! Thanks for sending this in!!

JoshuaKGoldberg

🧼

@OlivierZal

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.21.0 | 8.22.0 | | npm | @typescript-eslint/parser | 8.21.0 | 8.22.0 | ## [v8.22.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8220-2025-01-27) ##### 🩹 Fixes - **eslint-plugin:** \[no-unnecessary-template-expression] handle template literal type ([#10612](typescript-eslint/typescript-eslint#10612)) - **eslint-plugin:** \[prefer-readonly] autofixer doesn't add type to property that is mutated in the constructor ([#10552](typescript-eslint/typescript-eslint#10552)) - **eslint-plugin:** \[no-extraneous-class] handle accessor keyword ([#10678](typescript-eslint/typescript-eslint#10678)) - **eslint-plugin:** \[no-shadow] don't report unnecessarily on valid ways of using module augmentation ([#10616](typescript-eslint/typescript-eslint#10616)) - **eslint-plugin:** \[no-duplicate-type-constituents] handle nested types ([#10638](typescript-eslint/typescript-eslint#10638)) - **eslint-plugin:** \[prefer-nullish-coalescing] doesn't report on ternary but on equivalent || ([#10517](typescript-eslint/typescript-eslint#10517)) ##### ❤️ Thank You - mdm317 - Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal) - Ronen Amiel - YeonJuan [@yeonjuan](https://github.com/yeonjuan) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

@OlivierZal

| datasource | package | from | to | | ---------- | -------------------------------- | ------ | ------ | | npm | @typescript-eslint/eslint-plugin | 8.21.0 | 8.22.0 | | npm | @typescript-eslint/parser | 8.21.0 | 8.22.0 | ## [v8.22.0](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#8220-2025-01-27) ##### 🩹 Fixes - **eslint-plugin:** \[no-unnecessary-template-expression] handle template literal type ([#10612](typescript-eslint/typescript-eslint#10612)) - **eslint-plugin:** \[prefer-readonly] autofixer doesn't add type to property that is mutated in the constructor ([#10552](typescript-eslint/typescript-eslint#10552)) - **eslint-plugin:** \[no-extraneous-class] handle accessor keyword ([#10678](typescript-eslint/typescript-eslint#10678)) - **eslint-plugin:** \[no-shadow] don't report unnecessarily on valid ways of using module augmentation ([#10616](typescript-eslint/typescript-eslint#10616)) - **eslint-plugin:** \[no-duplicate-type-constituents] handle nested types ([#10638](typescript-eslint/typescript-eslint#10638)) - **eslint-plugin:** \[prefer-nullish-coalescing] doesn't report on ternary but on equivalent || ([#10517](typescript-eslint/typescript-eslint#10517)) ##### ❤️ Thank You - mdm317 - Olivier Zalmanski [@OlivierZal](https://github.com/OlivierZal) - Ronen Amiel - YeonJuan [@yeonjuan](https://github.com/yeonjuan) You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website.

mdm317 added 2 commits January 18, 2025 20:46

fix : handle accessor keyword

8081b16

test: change test code

b7f651b

test : add invalid case

5b19f63

mdm317 marked this pull request as ready for review January 20, 2025 09:25

ronami requested changes Jan 22, 2025

View reviewed changes

packages/eslint-plugin/src/rules/no-extraneous-class.ts Show resolved Hide resolved

ronami added the awaiting response Issues waiting for a reply from the OP or another party label Jan 22, 2025

fix : apply for abstract class

2b512a7

mdm317 requested a review from ronami January 23, 2025 10:32

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Jan 23, 2025

ronami approved these changes Jan 23, 2025

View reviewed changes

ronami added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jan 23, 2025

JoshuaKGoldberg approved these changes Jan 24, 2025

View reviewed changes

JoshuaKGoldberg merged commit a3a157c into typescript-eslint:main Jan 24, 2025
63 of 65 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(eslint-plugin): [no-extraneous-class] handle accessor keyword #10678

fix(eslint-plugin): [no-extraneous-class] handle accessor keyword #10678

Uh oh!

mdm317 commented Jan 18, 2025

Uh oh!

typescript-eslint bot commented Jan 18, 2025

Uh oh!

nx-cloud bot commented Jan 18, 2025 •

edited

Loading

Uh oh!

netlify bot commented Jan 18, 2025 •

edited

Loading

Uh oh!

ronami left a comment

Uh oh!

Uh oh!

codecov bot commented Jan 23, 2025 •

edited

Loading

Uh oh!

ronami left a comment

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix(eslint-plugin): [no-extraneous-class] handle accessor keyword #10678

fix(eslint-plugin): [no-extraneous-class] handle accessor keyword #10678

Uh oh!

Conversation

mdm317 commented Jan 18, 2025

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Jan 18, 2025

Uh oh!

nx-cloud bot commented Jan 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Jan 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

ronami left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ronami left a comment

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nx-cloud bot commented Jan 18, 2025 •

edited

Loading

netlify bot commented Jan 18, 2025 •

edited

Loading

codecov bot commented Jan 23, 2025 •

edited

Loading